-
Notifications
You must be signed in to change notification settings - Fork 138
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(Export Modal): Focus moves to parent page #6077
Merged
anamikaanu96
merged 8 commits into
carbon-design-system:main
from
sangeethababu9223:fix/export-modal-focus-moves-out
Sep 24, 2024
Merged
fix(Export Modal): Focus moves to parent page #6077
anamikaanu96
merged 8 commits into
carbon-design-system:main
from
sangeethababu9223:fix/export-modal-focus-moves-out
Sep 24, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sangeethababu9223
requested review from
makafsal and
AlexanderMelox
and removed request for
a team
September 19, 2024 06:40
✅ Deploy Preview for carbon-for-ibm-products ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
anamikaanu96
requested changes
Sep 24, 2024
packages/ibm-products/src/components/ExportModal/ExportModal.tsx
Outdated
Show resolved
Hide resolved
…/sangeethababu9223/ibm-products into fix/export-modal-focus-moves-out
makafsal
approved these changes
Sep 24, 2024
anamikaanu96
approved these changes
Sep 24, 2024
Merged
via the queue into
carbon-design-system:main
with commit Sep 24, 2024
ef4bfa8
22 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #6021
Focus moves to the parent page body after clicking submit button.
What did you change?
Moved focus back to close button on the modal.
How did you test and verify your work?
Storybook