Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update accessibility-checker version #6525

Merged
merged 10 commits into from
Dec 4, 2024

Conversation

makafsal
Copy link
Member

@makafsal makafsal commented Dec 3, 2024

Closes #6476

What did you change?

Update accessibility-checker version from 3.1.65 to 3.1.78

How did you test and verify your work?

yarn test

Copy link

netlify bot commented Dec 3, 2024

Deploy Preview for carbon-for-ibm-products ready!

Name Link
🔨 Latest commit 11d249c
🔍 Latest deploy log https://app.netlify.com/sites/carbon-for-ibm-products/deploys/674ff095aa056c0008e536cd
😎 Deploy Preview https://deploy-preview-6525--carbon-for-ibm-products.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Dec 3, 2024

Deploy Preview for ibm-products-web-components ready!

Name Link
🔨 Latest commit 11d249c
🔍 Latest deploy log https://app.netlify.com/sites/ibm-products-web-components/deploys/674ff09576d3b00008b7df4c
😎 Deploy Preview https://deploy-preview-6525--ibm-products-web-components.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Dec 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.91%. Comparing base (6b0a75b) to head (11d249c).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6525   +/-   ##
=======================================
  Coverage   79.91%   79.91%           
=======================================
  Files         394      394           
  Lines       12887    12887           
  Branches     4265     4265           
=======================================
  Hits        10299    10299           
  Misses       2588     2588           
Components Coverage Δ
ibm-products ∅ <ø> (∅)
ibm-products-web-components ∅ <ø> (∅)

@makafsal makafsal marked this pull request as ready for review December 4, 2024 06:02
@makafsal makafsal requested a review from a team as a code owner December 4, 2024 06:02
@makafsal makafsal requested review from elycheea and AlexanderMelox and removed request for a team December 4, 2024 06:02
Copy link
Contributor

@amal-k-joy amal-k-joy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@amal-k-joy amal-k-joy enabled auto-merge December 4, 2024 13:44
Copy link
Contributor

@davidmenendez davidmenendez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you for looking into this!

@amal-k-joy amal-k-joy added this pull request to the merge queue Dec 4, 2024
Merged via the queue into carbon-design-system:main with commit d8c7051 Dec 4, 2024
32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AxiosError in CreatefullPage test failure causing builds to break
3 participants