chore(createtearsheet): rename slug to decorator #6602
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sangeethababu9223
requested review from
makafsal and
matthewgallo
and removed request for
a team
✅ Deploy Preview for carbon-for-ibm-products ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for ibm-products-web-components ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6602 +/- ##
==========================================
- Coverage 80.78% 80.64% -0.14%
==========================================
Files 396 397 +1
Lines 12894 12919 +25
Branches 4275 4285 +10
==========================================
+ Hits 10416 10419 +3
- Misses 2478 2500 +22
|
amal-k-joy
previously approved these changes
Jan 2, 2025
sangeethababu9223
changed the title
sangeethababu9223
changed the title
amal-k-joy
approved these changes
Jan 6, 2025
makafsal
approved these changes
Jan 7, 2025
Merged
via the queue into
carbon-design-system:main
with commit Jan 7, 2025
04bc054
30 of 31 checks passed
sangeethababu9223
deleted the
chore/create-tearsheet-rename-slug-to-decorator
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #6661
Rename slug prop to decorator in CreateTearsheet
What did you change?
Updated the prop name
slugin CreateTearsheet file and stories todecorator.Added an extra option in controls to show non AILabel components being passed as
decoratorHow did you test and verify your work?
Storybook