Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change new_proposal.py to be upstream-agnostic #1899

Closed
jonmeow opened this issue Aug 3, 2022 · 1 comment · Fixed by #4681
Closed

Change new_proposal.py to be upstream-agnostic #1899

jonmeow opened this issue Aug 3, 2022 · 1 comment · Fixed by #4681
Labels
infrastructure long term Issues expected to take over 90 days to resolve.

Comments

@jonmeow
Copy link
Contributor

jonmeow commented Aug 3, 2022

There are issues with specifying push -u origin in new_proposal.py. gh can result in a repo either using upstream+origin, or origin+fork, with the second name being the fork in both cases. Either we need to use gh pr create alone (which may be ideal) or change the git push to be agnostic about the name (likely having to detect which to use, or at least if origin is incorrect).
@github-actions
Copy link

github-actions bot commented Nov 2, 2022

We triage inactive PRs and issues in order to make it easier to find active work. If this issue should remain active or becomes active again, please comment or remove the inactive label. The long term label can also be added for issues which are expected to take time.
This issue is labeled inactive because the last activity was over 90 days ago.

@github-actions github-actions bot added the inactive Issues and PRs which have been inactive for at least 90 days. label Nov 2, 2022
@jonmeow jonmeow added long term Issues expected to take over 90 days to resolve. and removed inactive Issues and PRs which have been inactive for at least 90 days. labels Jul 17, 2024
@jonmeow jonmeow mentioned this issue Dec 13, 2024
Merged
github-merge-queue bot pushed a commit that referenced this issue Dec 13, 2024
@danakj
Add a --remote switch to new_proposal.py (#4681)
18d9935 
If the user's fork is not named 'origin' then the script will fail and
needs to know the user's remote name.

Fixes #1899
bricknerb pushed a commit to bricknerb/carbon-lang that referenced this issue Dec 16, 2024
@danakj @bricknerb
Add a --remote switch to new_proposal.py (carbon-language#4681)
a4f8811 
If the user's fork is not named 'origin' then the script will fail and
needs to know the user's remote name.

Fixes carbon-language#1899
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
infrastructure long term Issues expected to take over 90 days to resolve.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add a --remote switch to new_proposal.py danakj/carbon-lang
1 participant
@jonmeow