Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Need design updates for #2015 numeric type literal syntax #2159

Closed
zygoloid opened this issue Sep 8, 2022 · 6 comments · Fixed by #2410
Closed

Need design updates for #2015 numeric type literal syntax #2159

zygoloid opened this issue Sep 8, 2022 · 6 comments · Fixed by #2410
Assignees
Labels
design update Action items to update docs/design based on approved proposals and leads decisions good first issue Possibly a good first issue for newcomers

Comments

@zygoloid
Copy link
Contributor

zygoloid commented Sep 8, 2022

We need updates to docs/design corresponding to proposal #2015.

@zygoloid zygoloid added good first issue Possibly a good first issue for newcomers design update Action items to update docs/design based on approved proposals and leads decisions labels Sep 8, 2022
@Aniumbott
Copy link

I'm new here I would be glad to work on it but will need a little guidance if someone can join along or can have a mentor if possible. 🥺

@zygoloid
Copy link
Contributor Author

Hi @Aniumbott, welcome to the Carbon project! I'm happy to provide some guidance here.

What we'd be looking for here is a pull request updating the .md files in docs/design:

  • Read through all the current parts of the design that discuss integer and floating-point type literals, and change them as needed to ensure that they match Numeric type literal syntax #2015.
  • Make sure that all design details mentioned in Numeric type literal syntax #2015 are reflected somewhere suitable in docs/design.
  • Add references back to the proposal from the design, both in the "References" section and in the "Alternatives considered" section in each file. See the design style guide for details.

Let me know if you have questions -- feel free to message me on discord.

@paulfryzel
Copy link
Contributor

@Aniumbott As the author of #2015, also feel free to ping me on Discord (paulfryzel) for any additional context or clarification you may need. Best of luck starting out on it!

@PramodhTVK
Copy link

Hello,I am very new to this language allthough I know a good amount of C++.I would love to contribute.Could you guys pls help me out?

@geoffromer
Copy link
Contributor

@PramodhTVK It sounds like you're asking for help with contributing to Carbon in general, rather than this issue in particular? If so, please take a look at CONTRIBUTING.md.

@avicorp
Copy link
Contributor

avicorp commented Nov 13, 2022

@Aniumbott As the author of #2015, also feel free to ping me on Discord (paulfryzel) for any additional context or clarification you may need. Best of luck starting out on it!

Hi, I started looking at the task and followed @zygoloid guidelines. I sow that #2015 mentioned at the reference section in two places and that the concept of iN, uN and fN introduced in the design.md.

I edit the numeric_literal.md and add referanse where #2015 was mentioned.

Can you assign me to the task and I will commit the change.

josh11b added a commit that referenced this issue Dec 9, 2022
Edit numeric literal design for the literal type proposal and add reference where #2015 was mentioned.

Closes #2159 

Co-authored-by: Richard Smith <richard@metafoo.co.uk>
Co-authored-by: josh11b <josh11b@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
design update Action items to update docs/design based on approved proposals and leads decisions good first issue Possibly a good first issue for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants