[executable semantics] if2.6c example segfaults #311
Assignees
Comments
dabrahams
pushed a commit
that referenced
this issue
Feb 28, 2021
* Add assertion to detect UB in interpreter.cpp This change, applied to 2111b85 ("Adapting jsiek's executable semantics tooling for commit. (#237)"), causes the if2.6c test to segfault. Becase the assertion fires only when `stmt == nullptr` and no code has permission to change `stmt` (it is `const`) before it is dereferenced in the `switch`, and nothiing in `PrintStatement` is supposed to exit the program, the assertion is a valid change that detects a bug. The crash was originally manifest in 0213c6d ("Executable Semantics: 1st-class stacks (#296)"). * Temporarily disable the if2 test pending #311 See #311 * [executable semantics] Record exit code on expected error. This will prevent a final segfault from sneaking by, detected as a passing test. A more principled follow-up commit would bottleneck detected error exit reporting and have it write something to std::cerr that can be recognized.
|
This bug should be fixed with the following PR |
|
@jsiek then you should feel free to close it, along with saying so. At least that's how it is on most projects I've worked on. Also see https://github.blog/2013-01-22-closing-issues-via-commit-messages/ |
|
Ok, thanks for the tip!
BTW, the fix is in #323 which hasn’t landed yet.
… On Mar 2, 2021, at 10:00 AM, Dave Abrahams ***@***.***> wrote:
@jsiek <https://github.com/jsiek> then you should feel free to close it, along with saying so. At least that's how it is on most projects I've worked on. Also see https://github.blog/2013-01-22-closing-issues-via-commit-messages/ <https://github.blog/2013-01-22-closing-issues-via-commit-messages/>
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub <#311 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AA5IGPDDNCI5YIOMQOHHLDTTBT4SDANCNFSM4YKRWOGQ>.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The if2.6c example segfaults. I'm currently in the process of temporarily disabling it and making our build not hide the problem. #312 will disable the test by commenting it out of the
BUILDfile.The text was updated successfully, but these errors were encountered: