Store named constant values in the AST #1011
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This enables us to stop using `Env` in the typechecker. As a byproduct, this commit also restructures the interpreter to handle run-time global initialization as part of ordinary execution, using the Action stack.
jsiek
reviewed
Jan 13, 2022
| } | ||
| } | ||
|
|
||
| void ActionStack::FinishAction(Nonnull<const Value*> result) { | ||
| std::unique_ptr<Action> act = todo_.Pop(); | ||
| switch (act->kind()) { | ||
| case Action::Kind::StatementAction: | ||
| FATAL() << "Statements cannot produce results."; | ||
| case Action::Kind::DeclarationAction: | ||
| FATAL() << "This kind of Action cannot produce results."; |
There was a problem hiding this comment.
"This" is too vague in the error message.
There was a problem hiding this comment.
OK, updated this to log the action as well.
chandlerc
pushed a commit
that referenced
this pull request
Jun 28, 2022
This enables us to stop using `Env` in the typechecker. As a byproduct, this commit also restructures the interpreter to handle run-time global initialization as part of ordinary execution, using the Action stack.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This enables us to stop using
Envin the typechecker. As a byproduct, this commit also restructures the interpreter to handle run-time global initialization as part of ordinary execution, using the Action stack.