Hide Interpreter in .cpp
#1036
Merged
Hide Interpreter in .cpp
#1036
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This improves encapsulation, and makes Interpreter lifetimes clearer (and shorter).
jonmeow
reviewed
Jan 21, 2022
| @@ -27,6 +27,83 @@ using llvm::isa; | |||
|
|
|||
| namespace Carbon { | |||
|
|
|||
| // Tag types for selecting Interpreter constructors. | |||
| struct CompileTimeTag {}; | |||
There was a problem hiding this comment.
I think you're doing this to disambiguate constructor overloads. My sense is that a factory method would be a more common approach (MakeRunTime/MakeCompileTime), although an enum (e.g., todo_(mode == RunTime ? &heap_ : nullptr)) is also something I'm used to seeing. What do you think of switching approaches?
There was a problem hiding this comment.
Factory methods don't really help here, because I need to conditionally pass one member to the constructor of another, which can only happen during construction, not before or after. I've redone this to use an enum, but I'm not convinced it's a net improvement. WDYT?
Co-authored-by: Jon Meow <46229924+jonmeow@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This improves encapsulation, and makes Interpreter lifetimes clearer (and shorter).