-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refining the precedence chart with if
, struct literals, and links.
#1089
Conversation
Co-authored-by: Richard Smith <richard@metafoo.co.uk>
Co-authored-by: Richard Smith <richard@metafoo.co.uk>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note, the links didn't work, fixing them requires tossing a pre-commit (I'll figure out an alternative, I'm just unhappy now)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, happy for you to either re-add struct literals here or as a separate PR if you prefer.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm happy with having a different precedence group for parens vs braces here, if that's what we need to do for links to work.
…1089) This is intended to be a more iterative edit to the chart: - Adding `if` and struct literals, since it came up in arithmetic. - Adding links to address a comment of mine about wanting references - Rephrasing slightly to reduce the implication that it's only for operators (particularly since I don't think we want to call `if` an operator) - Shifting operators below because similar Co-authored-by: Richard Smith <richard@metafoo.co.uk>
This is intended to be a more iterative edit to the chart:
if
and struct literals, since it came up in arithmetic.if
an operator)