-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement the current set of rules for precedence partial ordering #1096
Merged
Merged
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
a2895a6
Implement the current set of rules for precedence partial ordering.
zygoloid 42eae7b
Move description of precedence handling into README.md and expand it a
zygoloid 295fe3c
Retry specifying teletype font following #1089.
zygoloid 5e2dc6a
Reverse arrow direction.
zygoloid 8121c27
Fix reduce-reduce conflict in example grammar, following the pattern
zygoloid eb725ce
Consistently use 'x' for operator tokens in the example grammar.
zygoloid 0dc4665
Improve comment.
zygoloid File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Non-blocking comment: reading this section, I still have a hard time working out what rules I should follow when adding/modifying grammar rules, or conversely how to read grammar rules to understand the structure they describe. I think part of the issue is that the "what" (as opposed to "why") part is split between the idealised rules on lines 45-63 and the modifications to that ideal on lines 96-102.
However, I'm not sure that trying to wordsmith this is a good use of time right now; we'll probably have a better idea of how to clarify this once we've worked with it for a while. I think all the necessary information is here (modulo my question below), and that's probably enough for now.