-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Carbon: Proposal tracking #11
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some additional comments based on looking at the actual structure this ends up with.
proposals/template.md
Outdated
# TODO: Initial proposal setup | ||
|
||
1. Create a GitHub tracking issue in this repo using | ||
[the template](https://github.com/carbon-language/carbon-lang/issues/new?template=proposal.md). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This template doesn't exist; should it be included as part of this PR?
Co-authored-by: Richard Smith <richard@metafoo.co.uk>
We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. ℹ️ Googlers: Go here for more info. |
1 similar comment
We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. ℹ️ Googlers: Go here for more info. |
docs/project/evolution.md
Outdated
You may optionally use the | ||
[Google Docs template](https://docs.google.com/document/d/1sqEnIWWZKTrtMz2XgD7_RqvogwbI0tBQjAZIvOabQsw/template/preview) | ||
for early proposal versions, which can be transferred to Markdown later. Using | ||
Google Docs can especially help iterate on a propsal with multiple authors. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Google Docs can especially help iterate on a propsal with multiple authors. | |
Google Docs can especially help iterate on a proposal with multiple authors. |
docs/project/evolution.md
Outdated
- If the proposal needs more changes: | ||
- Grant the author edit access to the Doc again. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The paragraph immediately above this section needs to be updated to reflect that the review manager no longer grants edit access.
@googlebot I fixed it. |
No description provided.