Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Carbon: Proposal tracking #11

Closed
wants to merge 11 commits into from
Closed

Carbon: Proposal tracking #11

wants to merge 11 commits into from

Conversation

jonmeow
Copy link
Contributor

@jonmeow jonmeow commented May 13, 2020

No description provided.

@jonmeow jonmeow requested review from chandlerc and removed request for chandlerc May 13, 2020 20:42
Copy link
Contributor

@chandlerc chandlerc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some additional comments based on looking at the actual structure this ends up with.

docs/project/commenting_guidelines.md Outdated Show resolved Hide resolved
docs/project/consensus_decision_making.md Outdated Show resolved Hide resolved
proposals/template.md Outdated Show resolved Hide resolved
docs/project/evolution.md Outdated Show resolved Hide resolved
# TODO: Initial proposal setup

1. Create a GitHub tracking issue in this repo using
[the template](https://github.com/carbon-language/carbon-lang/issues/new?template=proposal.md).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This template doesn't exist; should it be included as part of this PR?

proposals/template.md Outdated Show resolved Hide resolved
Co-authored-by: Richard Smith <richard@metafoo.co.uk>
@googlebot
Copy link

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

1 similar comment
@googlebot
Copy link

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

You may optionally use the
[Google Docs template](https://docs.google.com/document/d/1sqEnIWWZKTrtMz2XgD7_RqvogwbI0tBQjAZIvOabQsw/template/preview)
for early proposal versions, which can be transferred to Markdown later. Using
Google Docs can especially help iterate on a propsal with multiple authors.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Google Docs can especially help iterate on a propsal with multiple authors.
Google Docs can especially help iterate on a proposal with multiple authors.

- If the proposal needs more changes:
- Grant the author edit access to the Doc again.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The paragraph immediately above this section needs to be updated to reflect that the review manager no longer grants edit access.

@chandlerc
Copy link
Contributor

@googlebot I fixed it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants