Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document Discourse Forums and Discord Chat with links and how to join. #12

Merged
merged 5 commits into from
May 20, 2020

Conversation

jonmeow
Copy link
Contributor

@jonmeow jonmeow commented May 13, 2020

No description provided.

@jonmeow jonmeow requested review from chandlerc and zygoloid May 13, 2020 20:43
CONTRIBUTING.md Outdated
- [The GitHub carbon-language organization](https://github.com/orgs/carbon-language)
is used for our repositories. **To join:**

1. Ask an admin to send an invite, providing your GitHub account.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All of these steps say "ask an admin". Is this document describing the current invite-only process, or the future fully public process? I think if it is the current invite-only process, it should be an onboarding guide for admins (to onboard a new member, send invites in the following systems: ...) In fact, a contributor won't even see this document before they are invited to the organization.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is about the current process -- although, I'd also recommend against making assumptions about how a future process may differ.

Regarding the rest, I actually view CONTRIBUTING.md as a bit of a "getting started" guide. It instructs people to sign the CLA, agree to the code of conduct, etc. In that sense, I think as long as this section isn't too long (which, rendered, I don't think it adds much) then it's fine here.

Also, forums have 19 people, discord has 21, GitHub has 27. The invites still require people to take some action, so this stands as a reminder for how to get access too.

@jonmeow jonmeow merged commit 92378d6 into master May 20, 2020
@jonmeow jonmeow deleted the jperkins-discourse branch May 20, 2020 20:43
chandlerc pushed a commit that referenced this pull request Jun 28, 2022
#12)

Document Discourse Forums and Discord Chat with links and how to join.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants