Improve test coverage after #1256. #1286
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change updated a test to use a different example to make sure a diagnostic was still being exercised, but as a consequence lost test coverage of the situation the test was originally intended to cover. Add back the old test and put the new test into a different file.
josh11b
reviewed
May 26, 2022
|
|
||
| package ExplorerTest api; | ||
|
|
||
| // CHECK: COMPILATION ERROR: {{.*}}/explorer/testdata/impl/fail_impl_as_non_interface.carbon:[[@LINE+1]]: expected constraint after `as`, found value of type String |
There was a problem hiding this comment.
Is there any concern that the error message is bad, in that it says "value of type String" instead of "String" or "value of type Type"?
| interface Vector(Scalar:! Type) { | ||
| } | ||
|
|
||
| // CHECK: COMPILATION ERROR: {{.*}}/explorer/testdata/impl/fail_impl_as_parameterized.carbon:[[@LINE+1]]: Expected a type, but got Vector |
There was a problem hiding this comment.
This error message seems wrong too -- a type isn't expected in place of "Vector".
jsiek
approved these changes
May 26, 2022
chandlerc
pushed a commit
that referenced
this pull request
Jun 28, 2022
This change updated a test to use a different example to make sure a diagnostic was still being exercised, but as a consequence lost test coverage of the situation the test was originally intended to cover. Add back the old test and put the new test into a different file.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change updated a test to use a different example to make sure a
diagnostic was still being exercised, but as a consequence lost test
coverage of the situation the test was originally intended to cover.
Add back the old test and put the new test into a different file.