Initial support for constraints formed by combining interfaces #1307
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Very little works right now.
scope. This allows us to later find the sub-impls and pull out the right witness.
different syntactic forms.
to non-types. Change printing from using `=` to using `==` in line with discussion in weekly sync meeting.
jsiek
reviewed
Jun 5, 2022
jsiek
reviewed
Jun 5, 2022
jsiek
reviewed
Jun 6, 2022
| }; | ||
|
|
||
| // A collection of values that are known to be the same. | ||
| struct EqualityConstraint { |
There was a problem hiding this comment.
Using a vector to keep track of equalities is likely to be inefficient. A better data structure for this purpose is union-find.
There was a problem hiding this comment.
Yeah, I have a TODO to add something more efficient, but any such approach depends on us having some way of looking up Values that's more efficient than a linear scan (such as hashing or canonicalization or similar). Do you want this addressed before this patch lands, or can we work on that as a separate step?
There was a problem hiding this comment.
Given the approval, I'm assuming it's fine to address this later :)
jsiek
reviewed
Jun 6, 2022
jsiek
approved these changes
Jun 6, 2022
chandlerc
pushed a commit
that referenced
this pull request
Jun 28, 2022
Add scaffolding for constraints in general, and support specifically constraints formed by applying a `&` operator. No support for constraints formed with `where` nor for named constraints at this point.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add scaffolding for constraints in general, and support specifically constraints formed by applying a
&operator.No support for constraints formed with
wherenor for named constraints at this point.