Handle PR reviews. #134
Merged
Handle PR reviews. #134
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
josh11b
approved these changes
Jul 31, 2020
chandlerc
pushed a commit
that referenced
this pull request
Jun 28, 2022
The main comment on a review wasn't being handled, and this change interleaves it with the PR comments. GitHub treats these as different entities. I'm hiding reviews with no top-level comment; these didn't seem worth including empty comments. Links are being added to PR comments to make them easier to find. This means indenting the content, so now all comments (PR or review thread) are consistently indented, removing a parameter. Also, I'm adjusting the formatting of review threads to match. snippets for comparison: ``` #83 (comment) googlebot: All (the pull request submitter and all commit authors) CLAs are... #83 (review) chandlerc: Overall, I think this is a pretty significant improved direction... ``` and from a review thread: ``` https://github.com/carbon-language/carbon-lang/pull/83/files/9863da8#diff-8f28081abb21e65fba5a0b0b29404c78R16 - line 16; unresolved - diff: https://github.com/carbon-language/carbon-lang/pull/83/files/9863da8..HEAD#diff-8f28081abb21e65fba5a0b0b29404c78L16 josh11b: ```suggestion¶ - Block comments begin with a line starting with `/... jonmeow: "begin with a line starting with" phrasing is a little confusing t... josh11b: As I understand @zygoloid 's lexing proposal, there may be additio... jonmeow: Rewritten with example ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main comment on a review wasn't being handled, and this change interleaves it with the PR comments. GitHub treats these as different entities.
I'm hiding reviews with no top-level comment; these didn't seem worth including empty comments.
Links are being added to PR comments to make them easier to find. This means indenting the content, so now all comments (PR or review thread) are consistently indented, removing a parameter. Also, I'm adjusting the formatting of review threads to match.
snippets for comparison:
and from a review thread: