Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create decision for proposal 42 (Code Review Guidelines) #137

Closed
wants to merge 4 commits into from
Closed

Create decision for proposal 42 (Code Review Guidelines) #137

wants to merge 4 commits into from

Conversation

sidney13
Copy link
Contributor

@sidney13 sidney13 commented Aug 4, 2020

This decision is now entering the decision comment period, and, assuming no substantive issues, will be finalized on 2020-08-18.

@googlebot googlebot added the cla: yes PR meets CLA requirements according to bot. label Aug 4, 2020
@sidney13 sidney13 added the proposal accepted Decision made, proposal accepted label Aug 4, 2020
jonmeow
jonmeow reviewed Aug 5, 2020
View reviewed changes
@sidney13 @jonmeow
Update proposals/p0042-decision.md
d6c6c41 
Co-authored-by: Jon Meow <46229924+jonmeow@users.noreply.github.com>
chandlerc
chandlerc approved these changes Aug 12, 2020
View reviewed changes
Copy link
Contributor

@chandlerc chandlerc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You'll want to run the pre-commit actions here to update the index of proposals.

You can do this by running it explicitly with pre-commit -a. Note that #141 should probably land first or you'll get extraneous changes from that.

chandlerc
chandlerc approved these changes Aug 27, 2020
View reviewed changes
Copy link
Contributor

@chandlerc chandlerc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Finally merged the actual proposal. Sorry for delay, but this should be good-to-go!

@sidney13 sidney13 mentioned this pull request Oct 16, 2020
Merged
@sidney13
Copy link
Contributor Author

This PR is being abandoned due to git merge issues. It has been replaces with PR #176 .

@sidney13 sidney13 closed this Oct 16, 2020
sidney13 added a commit that referenced this pull request Oct 16, 2020
@sidney13
Decision for proposal #42 (Create code review guidelines) (#176)
c82140a 
* Decision for proposal #42 (Create code review guidelines)

This is a recreation of PR #137 that got stuck in git merge hell.

* Results of running pre-commit
@sidney13 sidney13 deleted the code_review_decision branch December 9, 2020 01:34
chandlerc pushed a commit that referenced this pull request Jun 28, 2022
@sidney13
Decision for proposal #42 (Create code review guidelines) (#176)
4e81e25 
* Decision for proposal #42 (Create code review guidelines)

This is a recreation of PR #137 that got stuck in git merge hell.

* Results of running pre-commit
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonmeow jonmeow jonmeow left review comments

@chandlerc chandlerc chandlerc approved these changes

@geoffromer geoffromer Awaiting requested review from geoffromer

Assignees
No one assigned
Labels
cla: yes PR meets CLA requirements according to bot. proposal accepted Decision made, proposal accepted
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sidney13 @chandlerc @jonmeow @googlebot