Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Numeric literal semantics #144

Merged
merged 14 commits into from
Sep 24, 2021
Merged

Numeric literal semantics #144

merged 14 commits into from
Sep 24, 2021

Commits on Sep 17, 2021

  1. Numeric literal semantics

    @zygoloid
    zygoloid committed Sep 17, 2021
    Configuration menu
    Copy the full SHA
    bacdbbb View commit details
    Browse the repository at this point in the history

  2. Update based on recent discussion with @josh11b.

    @zygoloid
    zygoloid committed Sep 17, 2021
    Configuration menu
    Copy the full SHA
    5c68c3d View commit details
    Browse the repository at this point in the history

  3. Update to current syntax conventions.

    @zygoloid
    zygoloid committed Sep 17, 2021
    Configuration menu
    Copy the full SHA
    11cbfab View commit details
    Browse the repository at this point in the history

  4. Address some review feedback.

    @zygoloid
    zygoloid committed Sep 17, 2021
    Configuration menu
    Copy the full SHA
    9dc27e3 View commit details
    Browse the repository at this point in the history

Commits on Sep 18, 2021

  1. Don't say 'result' three times with three different meanings in the same 

    sentence.
    @zygoloid
    zygoloid committed Sep 18, 2021
    Configuration menu
    Copy the full SHA
    4e8fe12 View commit details
    Browse the repository at this point in the history

Commits on Sep 20, 2021

  1. Add more on how to write a function taking an arbitrary integer literal.

    @zygoloid
    zygoloid committed Sep 20, 2021
    Configuration menu
    Copy the full SHA
    35bf1d8 View commit details
    Browse the repository at this point in the history

Commits on Sep 21, 2021

  1. In order to support division of literals, we need to be able to 

    represent all rationals, not only dyadic and decadic rationals.

For example, we need to be able to represent 1.0 / 3.0 exactly.
    @zygoloid
    zygoloid committed Sep 21, 2021
    Configuration menu
    Copy the full SHA
    215f4a1 View commit details
    Browse the repository at this point in the history

Commits on Sep 22, 2021

  1. Rearrange and slightly expand description of the fixed-type literals 

    alternative.
    @zygoloid
    zygoloid committed Sep 22, 2021
    Configuration menu
    Copy the full SHA
    048fa3c View commit details
    Browse the repository at this point in the history

  2. Clarify that the same type is used for the numerator and denominator … 

    …of a Carbon.Rational.

Co-authored-by: Chandler Carruth <chandlerc@gmail.com>
    @zygoloid @chandlerc
    zygoloid and chandlerc authored Sep 22, 2021
    Configuration menu
    Copy the full SHA
    aa1ab61 View commit details
    Browse the repository at this point in the history

  3. Use Carbon digit separators instead of C++ digit separators. 

    Co-authored-by: Chandler Carruth <chandlerc@gmail.com>
    @zygoloid @chandlerc
    zygoloid and chandlerc authored Sep 22, 2021
    Configuration menu
    Copy the full SHA
    c8a9b90 View commit details
    Browse the repository at this point in the history

  4. Use relative link rather than absolute one. 

    Co-authored-by: Jon Meow <46229924+jonmeow@users.noreply.github.com>
    @zygoloid @jonmeow
    zygoloid and jonmeow authored Sep 22, 2021
    Configuration menu
    Copy the full SHA
    37ca5ea View commit details
    Browse the repository at this point in the history

  5. Updates addressing review comments.

    @zygoloid
    zygoloid committed Sep 22, 2021
    Configuration menu
    Copy the full SHA
    8b384da View commit details
    Browse the repository at this point in the history

  6. Merge branch 'trunk' into proposal-numeric-literal-sema

    @zygoloid
    zygoloid committed Sep 22, 2021
    Configuration menu
    Copy the full SHA
    11daecd View commit details
    Browse the repository at this point in the history

  7. Alternatives considered: add headings, remove unhelpful suggestion of 

    adding an AnyIntLiteral interface, clarify that two listed disadvantages
are covering two different possibilities.
    @zygoloid
    zygoloid committed Sep 22, 2021
    Configuration menu
    Copy the full SHA
    df2dd6a View commit details
    Browse the repository at this point in the history