-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Decision for p0143 - Numeric literals #167
Decision for p0143 - Numeric literals #167
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, I'd been wondering if I should ask for your painter's decision/rationale. :)
I'm going to add a two-week timeline for finalization of this decision starting today, given the delay in announcement. So Oct 6 seems fine.
All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the ℹ️ Googlers: Go here for more info. |
There are problematic merges on this PR. Please look at the set of affected files. It looks like you have a similar problem as occurred on #113 -- TBH I think there's a problem with your merge process because, while the CLA bot seems quirky, maybe the underlying issue is what's leading to the weird diffs of your changes. For myself, I run (essentially, I've got this scripted):
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(explicitly requesting changes)
Adds a decision and rationale for proposal #143. Co-authored-by: Jon Meow <46229924+jonmeow@users.noreply.github.com>
Adds a decision and rationale for proposal #143. Co-authored-by: Jon Meow <46229924+jonmeow@users.noreply.github.com>
Proposal #143 decision and rationale.
This decision is now entering the decision comment period, and, assuming
no substantive issues, will be finalized on 2020-10-06. This is a bit
slow because of some confusion after the decision was accepted --
I needed to write up the decision rather than the review manager.
Largely my bad letting it get lost. But it seems important to uphold the
usual comment window.