Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decision for p0143 - Numeric literals #167

Merged
merged 1 commit into from
Oct 16, 2020
Merged

Decision for p0143 - Numeric literals #167

merged 1 commit into from
Oct 16, 2020

Conversation

chandlerc
Copy link
Contributor

Proposal #143 decision and rationale.

This decision is now entering the decision comment period, and, assuming
no substantive issues, will be finalized on 2020-10-06. This is a bit
slow because of some confusion after the decision was accepted --
I needed to write up the decision rather than the review manager.
Largely my bad letting it get lost. But it seems important to uphold the
usual comment window.

@chandlerc chandlerc requested a review from jonmeow September 23, 2020 07:04
@googlebot googlebot added the cla: yes PR meets CLA requirements according to bot. label Sep 23, 2020
Copy link
Contributor

@jonmeow jonmeow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I'd been wondering if I should ask for your painter's decision/rationale. :)

I'm going to add a two-week timeline for finalization of this decision starting today, given the delay in announcement. So Oct 6 seems fine.

proposals/p0143_decision.md Show resolved Hide resolved
proposals/p0143_decision.md Outdated Show resolved Hide resolved
@jonmeow jonmeow added the proposal accepted Decision made, proposal accepted label Sep 23, 2020
@chandlerc chandlerc requested a review from a team October 16, 2020 08:38
@google-cla
Copy link

google-cla bot commented Oct 16, 2020

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

@google-cla google-cla bot added cla: no PR does not meet CLA requirements according to bot. and removed cla: yes PR meets CLA requirements according to bot. labels Oct 16, 2020
@chandlerc chandlerc requested a review from jonmeow October 16, 2020 08:39
@jonmeow
Copy link
Contributor

jonmeow commented Oct 16, 2020

There are problematic merges on this PR. Please look at the set of affected files. It looks like you have a similar problem as occurred on #113 -- TBH I think there's a problem with your merge process because, while the CLA bot seems quirky, maybe the underlying issue is what's leading to the weird diffs of your changes.

For myself, I run (essentially, I've got this scripted):

git checkout trunk
git fetch -p
git fetch upstream
git merge upstream/trunk
git push
git checkout $BRANCH
git merge trunk

Copy link
Contributor

@jonmeow jonmeow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(explicitly requesting changes)

@google-cla google-cla bot added cla: yes PR meets CLA requirements according to bot. and removed cla: no PR does not meet CLA requirements according to bot. labels Oct 16, 2020
Adds a decision and rationale for proposal #143.

Co-authored-by: Jon Meow <46229924+jonmeow@users.noreply.github.com>
@chandlerc chandlerc merged commit d84ab6c into carbon-language:trunk Oct 16, 2020
@chandlerc chandlerc deleted the numeric-literals-decision branch October 16, 2020 21:54
chandlerc added a commit that referenced this pull request Jun 28, 2022
Adds a decision and rationale for proposal #143.

Co-authored-by: Jon Meow <46229924+jonmeow@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes PR meets CLA requirements according to bot. proposal accepted Decision made, proposal accepted
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants