Code

Comments#198

Code

Merged

zygoloid merged 18 commits intocarbon-language:trunkcarbon-language/carbon-lang:trunkfrom zygoloid:proposal-commentsCopy head branch name to clipboardMar 1, 2021

+470

Commits

Commits on Nov 18, 2020

• Filling out template with PR 198

  zygoloid

  committed
  d761200

  Copy full SHA for d761200

Commits on Nov 19, 2020

• First draft of Comments proposal, extracted from Proposal 17.

  zygoloid

  committed
  d669407

  Copy full SHA for d669407

• More commentary and rationale.

  zygoloid

  committed
  3a94646

  Copy full SHA for 3a94646

Commits on Nov 21, 2020

• Partially address review comments

  zygoloid

  committed
  3f40a76

  Copy full SHA for 3f40a76

Commits on Dec 9, 2020

• Remove documentation comment syntax, in favor of a possible

  Show description for d99353c
  zygoloid

  committed
  d99353c

  Copy full SHA for d99353c

• Fix typo 'but' -> 'by'.

  Show description for 7cbac4c
  

  zygoloid

  and

  geoffromer

  authored
  7cbac4c

  Copy full SHA for 7cbac4c

Commits on Jan 26, 2021

• Remove block comments, at least for now.

  Show description for c1c9f4d
  zygoloid

  committed
  c1c9f4d

  Copy full SHA for c1c9f4d

• Fix bullet markdown.

  zygoloid

  committed
  ac5c1e9

  Copy full SHA for ac5c1e9

Commits on Jan 27, 2021

• Weaken text about documentation comments to avoid suggesting a decision

  Show description for 9e21253
  zygoloid

  committed
  9e21253

  Copy full SHA for 9e21253

Commits on Feb 1, 2021

• Apply suggestions from code review

  Show description for ef1f702
  

  zygoloid

  and

  chandlerc

  authored
  ef1f702

  Copy full SHA for ef1f702

• Updates based on review comments: pull use cases out to the start of the

  Show description for 2f34c67
  zygoloid

  committed
  2f34c67

  Copy full SHA for 2f34c67

• Update disadvantages of #if 0 in the face of the use case analysis.

  zygoloid

  committed
  c13428f

  Copy full SHA for c13428f

• Put the more important disadvantage first.

  zygoloid

  committed
  03d760f

  Copy full SHA for 03d760f

Commits on Feb 6, 2021

• Apply suggestions from code review

  Show description for 4473b58
  

  zygoloid

  and

  chandlerc

  authored
  4473b58

  Copy full SHA for 4473b58

Commits on Feb 10, 2021

• Rename "maintenance comments" to "implementation comments" based on

  Show description for 55a0187
  zygoloid

  committed
  55a0187

  Copy full SHA for 55a0187

Commits on Feb 25, 2021

• Merge branch 'trunk' into proposal-comments

  zygoloid

  committed
  bc2e9fc

  Copy full SHA for bc2e9fc

• Apply Prettier fix.

  zygoloid

  committed
  81a5297

  Copy full SHA for 81a5297

Commits on Mar 1, 2021

• Merge branch 'trunk' into proposal-comments

  zygoloid

  authored
  a55103b

  Copy full SHA for a55103b