Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Associated constant assignment versus equality #2173

Merged
merged 19 commits into from
Feb 1, 2023
Merged

Associated constant assignment versus equality #2173

merged 19 commits into from
Feb 1, 2023

Commits on Sep 13, 2022

  1. Proposal: associated constant assignment versus equality

    @zygoloid
    zygoloid committed Sep 13, 2022
    Configuration menu
    Copy the full SHA
    c13be2d View commit details
    Browse the repository at this point in the history

  2. Fill in remaining sections.

    @zygoloid
    zygoloid committed Sep 13, 2022
    Configuration menu
    Copy the full SHA
    6b83179 View commit details
    Browse the repository at this point in the history

Commits on Sep 15, 2022

  1. Fix typo. 

    Co-authored-by: josh11b <josh11b@users.noreply.github.com>
    @zygoloid @josh11b
    zygoloid and josh11b authored Sep 15, 2022
    Configuration menu
    Copy the full SHA
    5de17e2 View commit details
    Browse the repository at this point in the history

  2. Apply suggestions from code review

    @zygoloid
    zygoloid authored Sep 15, 2022
    Configuration menu
    Copy the full SHA
    591a1af View commit details
    Browse the repository at this point in the history

Commits on Sep 17, 2022

  1. Expand and add examples.

    @zygoloid
    zygoloid committed Sep 17, 2022
    Configuration menu
    Copy the full SHA
    a7cac91 View commit details
    Browse the repository at this point in the history

  2. Add some more considered alternatives.

    @zygoloid
    zygoloid committed Sep 17, 2022
    Configuration menu
    Copy the full SHA
    5854d0b View commit details
    Browse the repository at this point in the history

  3. Presubmit.

    @zygoloid
    zygoloid committed Sep 17, 2022
    Configuration menu
    Copy the full SHA
    2855d57 View commit details
    Browse the repository at this point in the history

Commits on Sep 21, 2022

  1. Respond to review comments.

    @zygoloid
    zygoloid committed Sep 21, 2022
    Configuration menu
    Copy the full SHA
    1ff011e View commit details
    Browse the repository at this point in the history

Commits on Sep 22, 2022

  1. Add precise rules and termination argument. 

    Remove the "recursively uses the same rewrite" rule which appears to be
unnecessary to guarantee termination.
    @zygoloid
    zygoloid committed Sep 22, 2022
    Configuration menu
    Copy the full SHA
    b039f41 View commit details
    Browse the repository at this point in the history

Commits on Dec 16, 2022

  1. Updates based on implementation experience.

    @zygoloid
    zygoloid committed Dec 16, 2022
    Configuration menu
    Copy the full SHA
    98bb5b3 View commit details
    Browse the repository at this point in the history

  2. Updates based on review feedback. Precommit.

    @zygoloid
    zygoloid committed Dec 16, 2022
    Configuration menu
    Copy the full SHA
    4801b9c View commit details
    Browse the repository at this point in the history

  3. Fix examples

    @zygoloid
    zygoloid authored Dec 16, 2022
    Configuration menu
    Copy the full SHA
    fcbec2a View commit details
    Browse the repository at this point in the history

  4. Apply suggestions from code review 

    Co-authored-by: josh11b <josh11b@users.noreply.github.com>
    @zygoloid @josh11b
    zygoloid and josh11b authored Dec 16, 2022
    Configuration menu
    Copy the full SHA
    b2e59e8 View commit details
    Browse the repository at this point in the history

  5. Update proposals/p2173.md

    @zygoloid
    zygoloid authored Dec 16, 2022
    Configuration menu
    Copy the full SHA
    5127c26 View commit details
    Browse the repository at this point in the history

Commits on Dec 17, 2022

  1. Add alternative considered for treatment of impl as.

    @zygoloid
    zygoloid committed Dec 17, 2022
    Configuration menu
    Copy the full SHA
    af7fc9c View commit details
    Browse the repository at this point in the history

Commits on Jan 3, 2023

  1. Update terminology to match carbon-language#2360 and address some min… 

    …or review

comments.
    @zygoloid
    zygoloid committed Jan 3, 2023
    Configuration menu
    Copy the full SHA
    03b5ceb View commit details
    Browse the repository at this point in the history

Commits on Jan 4, 2023

  1. Mention early on that we're restricting the syntax of where A = B, not 

    only changing the semantics.
    @zygoloid
    zygoloid committed Jan 4, 2023
    Configuration menu
    Copy the full SHA
    b1b0b19 View commit details
    Browse the repository at this point in the history

  2. Disallow top-level rewrites in impl as and also in is constraints.

    @zygoloid
    zygoloid committed Jan 4, 2023
    Configuration menu
    Copy the full SHA
    33fa914 View commit details
    Browse the repository at this point in the history

Commits on Jan 31, 2023

  1. Address review comments.

    @zygoloid
    zygoloid committed Jan 31, 2023
    Configuration menu
    Copy the full SHA
    f853310 View commit details
    Browse the repository at this point in the history