Implement support for rewrite constraints #2276
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove old attempt to resolve witnesses; it's not needed any more.
constraints from its associated constants. The constraint for an interface is no longer the same as the interface itself, and may in general have multiple impl constraints.
Only enough for small-scale testing for now. The real algorithm here will follow later.
Make it handle witnesses properly, by performing incremental resolution of them in lexical order, and deferring all substitution until we've got values and witnesses for all things that might be referenced. Change syntactic GenericBindings so that their constraint type refers to that same binding rather than having its own binding. This is necessary to make substitution of their Self work properly.
Convert generic binding arguments to their parameter type.
jonmeow
approved these changes
Oct 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements basic support for rewrite constraints as proposed in #2173.
Support for associated constants and complex constraints in general is also made more robust: argument deduction now properly computes and substitutes witnesses, and interface declarations track a more correct description of the constraint that they introduce than the one we previously built.