Update comment lexing to match #198. #292
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fowles
approved these changes
Feb 24, 2021
| struct NoWhitespaceAfterCommentIntroducer { | ||
| static constexpr llvm::StringLiteral ShortName = "syntax-comments"; | ||
| static constexpr llvm::StringLiteral Message = | ||
| "Whitespace is required after '//'."; |
There was a problem hiding this comment.
nit: should we use markdown ` for quoting code in a message?
There was a problem hiding this comment.
I've asked for opinions in #toolchain, but I'd be happy with that as a convention.
There was a problem hiding this comment.
FWIW, I'm very supportive of generally using markdown notation in diagnostics where it fits. Markdown even has plausible nesting if/where we need it.
chandlerc
approved these changes
Feb 25, 2021
| struct NoWhitespaceAfterCommentIntroducer { | ||
| static constexpr llvm::StringLiteral ShortName = "syntax-comments"; | ||
| static constexpr llvm::StringLiteral Message = | ||
| "Whitespace is required after '//'."; |
There was a problem hiding this comment.
FWIW, I'm very supportive of generally using markdown notation in diagnostics where it fits. Markdown even has plausible nesting if/where we need it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.