Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expression phase terminology #2964

Merged
merged 3 commits into from
Jul 6, 2023
Merged

Expression phase terminology #2964

merged 3 commits into from
Jul 6, 2023

Conversation

josh11b
Copy link
Contributor

@josh11b josh11b commented Jun 30, 2023 •
edited
Loading

Update terminology around expression properties:

  • "value phase" -> "expression phase"
  • "symbolic value" -> "symbolic constant"
  • "constant" -> "template constant"
  • "constant or symbolic value" -> "constant"

Implements the decision in #1391 .

@josh11b josh11b added proposal A proposal proposal draft Proposal in draft, not ready for review labels Jun 30, 2023
@josh11b josh11b marked this pull request as ready for review June 30, 2023 23:42
@github-actions github-actions bot added proposal rfc Proposal with request-for-comment sent out and removed proposal draft Proposal in draft, not ready for review labels Jun 30, 2023
@github-actions github-actions bot requested a review from chandlerc June 30, 2023 23:43
chandlerc
chandlerc reviewed Jul 6, 2023
View reviewed changes
Copy link
Contributor

@chandlerc chandlerc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like a good, simple proposal to me. No comments really, thanks for documenting where we ended up here.

@jonmeow
Copy link
Contributor

jonmeow commented Jul 6, 2023

NB: Added an empty commit to unjam the test action, since it looks like this may be approved without edits.

chandlerc
chandlerc approved these changes Jul 6, 2023
View reviewed changes
Copy link
Contributor

@chandlerc chandlerc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving for leads.

@chandlerc chandlerc added this pull request to the merge queue Jul 6, 2023
Merged via the queue into carbon-language:trunk with commit e0e6840 Jul 6, 2023
@josh11b josh11b deleted the phase branch July 6, 2023 23:10
@josh11b josh11b mentioned this pull request Aug 1, 2023
Merged
github-merge-queue bot pushed a commit that referenced this pull request Aug 2, 2023
@josh11b @geoffromer @zygoloid
Update Generics terminology document (#3048)
587ab64 
This reflects changes from a number of approved proposals:
- #920 : concrete statements about orphan and overlap in Carbon
- #2138 : "generic" -> "checked generic", "template" -> "template
generic"
- #2188 : binding patterns are forbidden in type position
- #2360 : "type", "facet type", "facet". Note: I am not using the term
"generic type" from #2360 since that meaning conflicts with the
generally accepted meaning of "generic type" of a type with a
compile-time parameter.
- #2760 / #2770 : internal/external impl -> extending impl
- #2964 : "symbolic constant" and "template constant"

---------

Co-authored-by: Geoff Romer <gromer@google.com>
Co-authored-by: Richard Smith <richard@metafoo.co.uk>
@josh11b josh11b mentioned this pull request Aug 3, 2023
Merged
github-merge-queue bot pushed a commit that referenced this pull request Aug 15, 2023
@josh11b @zygoloid
Update generics overview (#3061)
e15bdbb 
This reflects changes from a number of approved proposals:

- #2138 : "generic" -> "checked generic", "template" -> "template
generic"
- #2360 : "type", "facet type", "facet". Note: I am not using the term
"generic type" from #2360 since that meaning conflicts with the
generally accepted meaning of "generic type" of a type with a
compile-time parameter.
- #2760 / #2770 : internal/external impl -> extending impl
- #2964 : "symbolic constant" and "template constant"

---------

Co-authored-by: Richard Smith <richard@metafoo.co.uk>
@josh11b josh11b mentioned this pull request Aug 25, 2023
Merged
github-merge-queue bot pushed a commit that referenced this pull request Aug 31, 2023
@josh11b @zygoloid
Update member_access.md to reflect accepted proposals (#3160)
d5d6945 
Most changes are due to proposal #2360, but this also includes changes
to reflect: #1136, #2138, #2006, #2550, and #2964.

---------

Co-authored-by: Richard Smith <richard@metafoo.co.uk>
@josh11b josh11b mentioned this pull request Aug 31, 2023
Merged
github-merge-queue bot pushed a commit that referenced this pull request Sep 8, 2023
@josh11b @zygoloid
Update design overview to reflect submitted proposals (#3180)
71f2eec 
Incorporates proposals: #1885, #2138, #2188, #2200, #2360, #2760, #2964,
and #3162.

---------

Co-authored-by: Richard Smith <richard@metafoo.co.uk>
@josh11b josh11b mentioned this pull request Sep 14, 2023
Merged
github-merge-queue bot pushed a commit that referenced this pull request Sep 19, 2023
@josh11b @zygoloid
Updates to generics design details, part 1 (#3231)
a8ca499 
First step in updating `docs/design/generics/details.md`. It
incorporates changes from proposals: #989 #2138 #2173 #2200 #2360 #2964
#3162 , but there are still more changes from those proposals to be
made.

It also switches away from suggesting static-dispatch witness tables,
and creates an appendix to describe that decision.

---------

Co-authored-by: Richard Smith <richard@metafoo.co.uk>
This was referenced Sep 22, 2023
Merged
Merged
github-merge-queue bot pushed a commit that referenced this pull request Sep 23, 2023
@josh11b @chandlerc
Updates to design docs to reflect accepted proposals (#3254)
58c1060 
Includes proposals:
- #990
- #2188
- #2138
- #2200
- #2360
- #2760
- #2964
- #3162

Also tries to use more precise language when talking about:
- implementations, to avoid confusing `impl` declaration and definitions
with the `impls` operator used in `where` clauses, an issue brought up
in #2495 and #2483;
- "binding patterns", like `x: i32`, and "bindings" like `x`.

---------

Co-authored-by: Chandler Carruth <chandlerc@gmail.com>
github-merge-queue bot pushed a commit that referenced this pull request Oct 3, 2023
@josh11b @zygoloid
Updates to generics design details, part 2 (#3253)
88e87b8 
Continued from part 1: #3231. Second step updating
`docs/design/generics/details.md`. There remains some work to
incorporate proposal #2200.

- The biggest changes are incorporating much of the text of proposals:
  - #2173
  - #2687
- It incorporates changes from proposals:
  - #989
  - #1178
  - #2138
  - #2200
  - #2360
  - #2964
  - #3162
- It also updates the text to reflect the latest thinking from leads
issues:
  - #996
  - #2153 -- most notably deleting the section on `TypeId`.
- Update to rule for prioritization blocks with mixed type structures
from [discussion on
2023-07-18](https://docs.google.com/document/d/1gnJBTfY81fZYvI_QXjwKk1uQHYBNHGqRLI2BS_cYYNQ/edit?resourcekey=0-ql1Q1WvTcDvhycf8LbA9DQ#heading=h.7jxges9ojgy3)
- Adds reference links to proposals, issues, and discussions relevant to
the text.
- Also tries to use more precise language when talking about
implementations, to avoid confusing `impl` declaration and definitions
with the `impls` operator used in `where` clauses, an issue brought up
in
  - #2495 
  - #2483

---------

Co-authored-by: Richard Smith <richard@metafoo.co.uk>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chandlerc chandlerc chandlerc approved these changes

Assignees
No one assigned
Labels
proposal rfc Proposal with request-for-comment sent out proposal A proposal
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@josh11b @jonmeow @chandlerc