Matching redeclarations #3763
Merged
Matching redeclarations #3763
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zygoloid
added
proposal
zygoloid
force-pushed
the
proposal-redeclarations
branch
from
9df4a27 to
ef12d93
Compare
jonmeow
reviewed
Mar 11, 2024
jonmeow
reviewed
Mar 11, 2024
github-actions
bot
added
proposal rfc
chandlerc
reviewed
Mar 16, 2024
chandlerc
reviewed
May 1, 2024
chandlerc
reviewed
May 14, 2024
jonmeow
reviewed
May 14, 2024
Co-authored-by: Chandler Carruth <chandlerc@gmail.com>
Co-authored-by: Carbon Infra Bot <carbon-external-infra@google.com>
CJ-Johnson
pushed a commit
to CJ-Johnson/carbon-lang
that referenced
this pull request
May 23, 2024
Require exact syntactic matching in redeclarations. Provide new terminology for redeclaration matching and agreement. Specify non-redeclaration rules for the other contexts where we require multiple declarations to match, such as `impl`s of `interfaces`, `impl`s of `virtual fn`s. --------- Co-authored-by: Chandler Carruth <chandlerc@gmail.com> Co-authored-by: Carbon Infra Bot <carbon-external-infra@google.com>
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jun 28, 2024
This refactors how the implicit import is handled in order to retain more name scope information. As a consequence, private access control works better between api files and implementation files. Note though that this will also be essential for name poisoning between the API and implementation, as discussed in #3763. In implementing this, I ran into a couple issues with namespaces that I think point to flaws in their handling. I've fixed some and added a TODO for the biggest issue (in check.cpp line 281-288), which relates to the handling of namespaces of direct imports which are first evaluated indirectly.
github-merge-queue bot
pushed a commit
that referenced
this pull request
Aug 21, 2024
Trying to pull in key elements of #3762, #3763, and #3980 (decl matching and `extern`, essentially). These aren't specific to any particular declaration type, but are common to entities, so suggesting a new doc oriented on that. There's probably more that could be said here, I'm just focused on getting the recent formal discussion mirrored into the design. --------- Co-authored-by: josh11b <15258583+josh11b@users.noreply.github.com>
github-merge-queue bot
pushed a commit
that referenced
this pull request
Sep 27, 2024
Update impl handling to more closely match other kinds of declaration, including support for declaring and defining gneeric `impl`s. When of performing redeclaration lookup for impls by looking for the self and constraint type, produce a list of impls rather than a single impl because it's possible for there to be multiple impls with different deduced parameters but the same self type and constraint. Following #3763, only consider impls to be redeclarations if they're spelled the same, not just if they have the same self and constraint types. No support yet for impl selection to deduce the arguments of a generic impl. --------- Co-authored-by: Jon Ross-Perkins <jperkins@google.com>
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jan 7, 2025
* Implement ignoring the difference between `Self as` and `as`, as well as `where` clauses at the end of an `impl` declaration when checking whether `impl` declarations match, from #3763. * Allow impl declarations with different constraint ids to match, as long as the facet type of the constraint has the same interface_id and specific_id. * Add some TODOs reflecting future facet type resolution. --------- Co-authored-by: Josh L <josh11b@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Require exact syntactic matching in redeclarations. Provide new terminology for
redeclaration matching and agreement. Specify non-redeclaration rules for the
other contexts where we require multiple declarations to match, such as
implsof
interfaces,impls ofvirtual fns.