Add basic output of where memory is stored after a compile. #4136
Conversation
toolchain/base/mem_usage.h
Outdated
| // auto CollectMemUsage(llvm::StringRef label, AddMemUsageFn add_mem_usage) | ||
| // const -> void; | ||
| // | ||
| // The label should be concatenated with any child labels using MemUsageLabel in |
There was a problem hiding this comment.
"MemUsageLabel" seems like it should be a function or something from this file, but this is the only mention of this word. Do you mean MemUsage::ConcatLabel?
There was a problem hiding this comment.
Fixed. Sorry, this is leftover from iterating on structure.
toolchain/base/mem_usage.h
Outdated
| // The arguments for AddMemUsageFn are the label and byte size. It should be | ||
| // called once per tracked size. |
There was a problem hiding this comment.
Out of date. Should say something about calling mem_usage.Add instead.
| template <typename T> | ||
| auto Collect(llvm::StringRef label, const T& arg) -> void { | ||
| arg.CollectMemUsage(*this, label); | ||
| } |
There was a problem hiding this comment.
What is the advantage of using this function instead of calling CollectMemUsage directly?
There was a problem hiding this comment.
I was trying to enforce a standard API, keeping arguments with similar structure.
I tried making this another Add overload, but I think BumpPtrAllocator gets a little hostile to overload resolution in a way I'm not able to solve.
i.e., as-is, parameters are in similar positions, with the tracked data last:
mem_usage.Collect(MemUsage::ConcatLabel(label, "values_"), values_);
mem_usage.Add(MemUsage::ConcatLabel(label, "canonical_blocks_"),
canonical_blocks_, KeyContext(this));
Otherwise, these are fundamentally different:
values_.CollectMemUsage(mem_usage, MemUsage::ConcatLabel(label, "values_"));
mem_usage.Add(MemUsage::ConcatLabel(label, "canonical_blocks_"),
canonical_blocks_, KeyContext(this));
toolchain/base/mem_usage.h
Outdated
| // called once per tracked size. | ||
| class MemUsage { | ||
| public: | ||
| auto Add(std::string label, int64_t used, int64_t reserved) -> void { |
There was a problem hiding this comment.
Clarify the units of used and reserved is bytes?
Co-authored-by: josh11b <15258583+josh11b@users.noreply.github.com>
Co-authored-by: josh11b <15258583+josh11b@users.noreply.github.com>
…anguage#4136) The output is really basic, I'm just adding this to help track how memory is allocated. ``` --- filename: 'check/testdata/expr_category/in_place_tuple_init.carbon' source_: used_bytes: 8057 reserved_bytes: 8057 tokens_.allocator_: used_bytes: 0 reserved_bytes: 0 tokens_.token_infos_: used_bytes: 1040 reserved_bytes: 2032 (eliding) value_stores_.string_literals_.set_: used_bytes: 320 reserved_bytes: 320 Total: used_bytes: 20609 reserved_bytes: 29437 ... ``` --------- Co-authored-by: josh11b <15258583+josh11b@users.noreply.github.com>
The output is really basic, I'm just adding this to help track how memory is allocated.