Do not query interface's self_param_id unless defined when importing #4137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Querying a local constant with an invalid instruction triggers a crash, this will prevent self_param_id to be used unless it is defined. Fixes carbon-language#4071 and carbon-language#4080
zygoloid
previously approved these changes
Jul 15, 2024
zygoloid
reviewed
Jul 15, 2024
zygoloid
dismissed
their stale review
Would like a test to be added before merging.
- Covers the test cases in carbon-language#4071 and carbon-language#4080 - Importing declaration works without an issue - Importing, then defining the interface throws a duplicate declaration issue since it is not yet implemented.
|
Added two cases to cover both issues 👍🏻 |
brymer-meneses
pushed a commit
to brymer-meneses/carbon-lang
that referenced
this pull request
Aug 15, 2024
…arbon-language#4137) Querying a local constant with an invalid instruction triggers a crash, this will prevent self_param_id to be used unless it is defined. Closes carbon-language#4071 and carbon-language#4080 This will only fix the crash. The scenario where a declaration-only interface is imported then defined still gives an error message, but it won't crash this time.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Querying a local constant with an invalid instruction triggers a crash, this will prevent self_param_id to be used unless it is defined.
Closes #4071 and #4080
This will only fix the crash. The scenario where a declaration-only interface is imported then defined still gives an error message, but it won't crash this time.