Enable the more effective version of -Wnon-virtual-dtor.
#4142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Most of this is enabled by default, but there is some that needs an explicit flag. Avoiding `-Wnon-virtual-dtor` itself for now because that warning can require changes that carry overhead such as having an extra, unused destructor entry in the vtable. Hopefully we don't have too many folks who need our code to be `-Wnon-virtual-dtor` clean.
zygoloid
approved these changes
Jul 17, 2024
brymer-meneses
pushed a commit
to brymer-meneses/carbon-lang
that referenced
this pull request
Aug 15, 2024
…nguage#4142) Most of this is enabled by default, but there is some that needs an explicit flag. Avoiding `-Wnon-virtual-dtor` itself for now because that warning can require changes that carry overhead such as having an extra, unused destructor entry in the vtable. Hopefully we don't have too many folks who need our code to be `-Wnon-virtual-dtor` clean.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most of this is enabled by default, but there is some that needs an explicit flag.
Avoiding
-Wnon-virtual-dtoritself for now because that warning can require changes that carry overhead such as having an extra, unused destructor entry in the vtable. Hopefully we don't have too many folks who need our code to be-Wnon-virtual-dtorclean.