Remove supurfluous/confusing {} around a temporary #4183
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was failing to build for me locally with some arbitrary Clang HEAD
host compiler:
migrate_cpp/rewriter.cpp:225:3: error: call to member function 'SetReplacement' is ambiguous
225 | SetReplacement(expr, {OutputSegment(std::move(text))});
| ^~~~~~~~~~~~~~
./migrate_cpp/rewriter.h:141:8: note: candidate function [with T = clang::IntegerLiteral]
141 | auto SetReplacement(const T* node, std::vector<OutputSegment> output_segments)
| ^
./migrate_cpp/rewriter.h:150:8: note: candidate function [with T = clang::IntegerLiteral]
150 | auto SetReplacement(const T* node, OutputSegment segment) -> void {
| ^
No idea if that's a bug in clang HEAD, but it seemed like removing the
{} simplified the code anyway - so here's that.
jonmeow
approved these changes
Aug 1, 2024
brymer-meneses
pushed a commit
to brymer-meneses/carbon-lang
that referenced
this pull request
Aug 15, 2024
) This was failing to build for me locally with some arbitrary Clang HEAD host compiler: ``` migrate_cpp/rewriter.cpp:225:3: error: call to member function 'SetReplacement' is ambiguous 225 | SetReplacement(expr, {OutputSegment(std::move(text))}); | ^~~~~~~~~~~~~~ ./migrate_cpp/rewriter.h:141:8: note: candidate function [with T = clang::IntegerLiteral] 141 | auto SetReplacement(const T* node, std::vector<OutputSegment> output_segments) | ^ ./migrate_cpp/rewriter.h:150:8: note: candidate function [with T = clang::IntegerLiteral] 150 | auto SetReplacement(const T* node, OutputSegment segment) -> void { | ^ ``` No idea if that's a bug in clang HEAD, but it seemed like removing the {} simplified the code anyway - so here's that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was failing to build for me locally with some arbitrary Clang HEAD host compiler:
No idea if that's a bug in clang HEAD, but it seemed like removing the {} simplified the code anyway - so here's that.