Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Distinguish between whether an entity has its own parameter lists and whether it is generic. #4191

Merged
merged 1 commit into from
Aug 6, 2024

Conversation

zygoloid
Copy link
Contributor

@zygoloid zygoloid commented Aug 6, 2024

It's actually possible to get into all four combinations of having parameter lists versus being generic:

  • An entity nested within a generic, such as a member class, can be generic even if it has no parameters.

  • As a corner case, an entity with an empty parameter list has parameter lists, but isn't a generic because it doesn't have any generic parameters.

… whether it is generic.

It's actually possible to get into all four combinations of having
parameter lists versus being generic:

- An entity nested within a generic, such as a member class, can be
  generic even if it has no parameters.

- As a corner case, an entity with an *empty* parameter list has
  parameter lists, but isn't a generic because it doesn't have any
  generic parameters.
@github-actions github-actions bot requested a review from josh11b August 6, 2024 00:24
Copy link
Contributor

@jonmeow jonmeow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@jonmeow jonmeow added this pull request to the merge queue Aug 6, 2024
Merged via the queue into carbon-language:trunk with commit f6ff5b1 Aug 6, 2024
9 checks passed
@zygoloid zygoloid deleted the toolchain-nested-generic branch August 7, 2024 00:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants