Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create code review guidelines #42

Merged
merged 49 commits into from
Aug 27, 2020
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
49 commits
Select commit Hold shift + click to select a range
250eeee
Proposal for an explicit GitHub workflow.
chandlerc May 27, 2020
b1ab93f
Addressing review comments.
chandlerc May 28, 2020
9df8f00
Merge branch 'master' into flow-linear
chandlerc May 30, 2020
f64d62c
Minor tweaks
chandlerc May 31, 2020
01491d1
Fix typo in CONTRIBUTING.md
chandlerc Jun 2, 2020
8e5e7e3
Extract workflow description and remove redundancies.
chandlerc Jun 2, 2020
e7f63a1
Merge branch 'master' into flow-linear
chandlerc Jun 3, 2020
4efe332
remove tracking issue template field
chandlerc Jun 3, 2020
71cb4a5
Update proposals/p0029.md with reviewer suggsetion.
chandlerc Jun 3, 2020
833e9b5
Continue to address review feedback.
chandlerc Jun 3, 2020
0a414f6
Apply suggestions from code review
chandlerc Jun 10, 2020
8075748
Incorporate code review feedback and begin moving toward "trunk" base…
chandlerc Jun 10, 2020
d07bc20
Merge branch 'master' into flow-linear
chandlerc Jun 10, 2020
2a9487d
Tweak the wording and make it a bit more consistent.
chandlerc Jun 10, 2020
934f708
Update docs/project/pull_request_workflow.md
chandlerc Jun 11, 2020
0bbed4a
Address more review comments.
chandlerc Jun 11, 2020
0fb8618
Correct the rationale.
chandlerc Jun 12, 2020
a5f6a2f
Merge branch 'master' into flow-linear
chandlerc Jun 17, 2020
e1ed39e
Tweak wording based on discussion in review.
chandlerc Jun 17, 2020
68c6adf
Improve the rationale around the default branch to avoid overstating or
chandlerc Jun 17, 2020
8d25246
Apply suggestions from code review
chandlerc Jun 20, 2020
a5dddbd
Clean up formatting and address a couple of comments on grammar from …
chandlerc Jun 20, 2020
10ce7a6
Merge branch 'master' into flow-linear
chandlerc Jun 20, 2020
e692c8b
Create proposal template doc.
chandlerc Jun 2, 2020
2040a43
WIP
chandlerc Jun 2, 2020
a06871b
tiny progress
chandlerc Jun 10, 2020
7bd2cd6
Actually write up the proposal
chandlerc Jun 22, 2020
3f1c3cc
Add the code review guidelines document.
chandlerc Jun 22, 2020
2205aea
Add CODEOWNERS files
chandlerc Jun 22, 2020
7680349
Apply suggestions from code review
chandlerc Jun 24, 2020
b2d51ba
Match proposal name.
chandlerc Jun 22, 2020
b8cf535
Major updates from review.
chandlerc Jun 25, 2020
73bd025
Address review comments on actual code owners.
chandlerc Jun 25, 2020
7a94342
Apply suggestions from code review
chandlerc Jun 27, 2020
1f2210a
Add a mention of testing based on review.
chandlerc Jun 27, 2020
6f18f45
Fix at least some of my spelling mistakes.
chandlerc Jun 27, 2020
c11a811
Some more improvements from review -- I originally missed these comme…
chandlerc Jun 27, 2020
f548bc1
Update docs/project/pull_request_workflow.md
chandlerc Jun 30, 2020
e9418e8
Merge branch 'master' into flow-linear
chandlerc Jul 1, 2020
8d3ff9a
Add to proposal list.
chandlerc Jul 1, 2020
0e907bb
Merge remote-tracking branch 'refs/remotes/origin/flow-linear' into c…
chandlerc Jul 2, 2020
6e0ba56
Merge branch 'master' into code-review
chandlerc Jul 2, 2020
01d2d6a
Apply suggestions from code review
chandlerc Jul 2, 2020
06bd76f
Adjustments from review.
chandlerc Jul 2, 2020
446d3e4
Apply suggestions from code review
chandlerc Jul 22, 2020
3e8fcb0
Address some review comments.
chandlerc Jul 22, 2020
2888b6e
Merge branch 'trunk' into code-review
chandlerc Aug 12, 2020
3d34e73
Re-format and update TOC
chandlerc Aug 12, 2020
d2b222c
Merge branch 'trunk' into code-review
chandlerc Aug 27, 2020
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions CODEOWNERS
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
# Global owners.
* @carbon-language/admin-team

# The core team owns the core language and project documentation.
/docs/ @carbon-language/core-team

# The review managers own updates to the proposals.
/proposals/ @carbon-language/review-managers

# This directory contains infrastructure and support scripts
/src/ @carbon-language/infra-team
Loading