Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust check's node formatting in crash output. #4217

Merged
merged 1 commit into from
Aug 14, 2024

Conversation

jonmeow
Copy link
Contributor

@jonmeow jonmeow commented Aug 14, 2024

I'm trying to make the line of code more clearly nested in crash output (the way it is, I sometimes forget about it). Also, Check::HandleFunctionDecl is the old naming scheme, it's now all Check::HandleParseNode, so I'm replacing that.

Before:

3.	extern_library_owner.carbon:6:1: Check::HandleFunctionDecl
extern fn F();
^~~~~~~~~~~~~~
 #0 0x0000564c0057ef1d llvm::sys::PrintStackTrace(llvm::raw_ostream&, int) ...

After:

3.	extern_library_owner.carbon:6:1: checking FunctionDecl
          extern fn F();
          ^~~~~~~~~~~~~~
 #0 0x00005629029ffd9d llvm::sys::PrintStackTrace(llvm::raw_ostream&, int) ...

Copy link
Contributor

@chandlerc chandlerc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG

@chandlerc chandlerc added this pull request to the merge queue Aug 14, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Aug 14, 2024
@jonmeow jonmeow added this pull request to the merge queue Aug 14, 2024
Merged via the queue into carbon-language:trunk with commit 3f7af84 Aug 14, 2024
9 checks passed
@jonmeow jonmeow deleted the node-indent branch August 14, 2024 21:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants