When a builtin function expects type T also allow an adapter for T. #4643
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Specifically, this allows builtin functions to be used with adapters without needing to perform an extra no-op conversion.
josh11b
reviewed
Dec 6, 2024
josh11b
approved these changes
Dec 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extends the set of function signatures that support being given a builtin definition to include cases where a parameter or return type is an adapter for a supported type. For example, if we can give a builtin definition to
Add(a: i32, b: i32) -> i32, then we can also give a builtin definition toAdd(a: MyI32, b: MyI32) - >MyI32whereMyI32adaptsi32.This is a prerequisite for changing
Core.Intto be a class type that adapts the builtin int type.