Include a fully-qualified name when stringifying types. #4657
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ensures that we can properly name entities imported indirectly.
zygoloid
force-pushed
the
toolchain-format-namespace
branch
from
0181d9a to
ba610d7
Compare
jonmeow
approved these changes
Dec 11, 2024
bricknerb
pushed a commit
to bricknerb/carbon-lang
that referenced
this pull request
Dec 16, 2024
…age#4657) For example, format the `ImplicitAs` interface as `Core.ImplicitAs` rather than simply `ImplicitAs`. When importing an entity in a namespace, also import a declaration of the enclosing namespace if necessary so that we can determine its name.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For example, format the
ImplicitAsinterface asCore.ImplicitAsrather than simplyImplicitAs.When importing an entity in a namespace, also import a declaration of the enclosing namespace if necessary so that we can determine its name.