Provide a location for monomorphization failures resulting from TryToCompleteType.
#4670
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replace all callers but one with a new function to complete a type or CHECK-fail.
josh11b
approved these changes
Dec 12, 2024
toolchain/check/context.cpp
Outdated
| return TypeCompleter(*this, loc, nullptr).Complete(type_id); | ||
| } | ||
|
|
||
| auto Context::CompleteTypeOrCheckFail(SemIR::TypeId type_id) -> void { | ||
| // TODO: We need a location here in case we need to instantiate a class type. |
There was a problem hiding this comment.
Is this TODO still relevant?
There was a problem hiding this comment.
Huh, I thought I deleted that. Removed now. Thanks!
bricknerb
pushed a commit
to bricknerb/carbon-lang
that referenced
this pull request
Dec 16, 2024
…oCompleteType`. (carbon-language#4670) Almost all callers actually could never fail and nearly all of those already `CHECK`-failed on failure. Add a new overload for that case, and add a location parameter for the one remaining call.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Almost all callers actually could never fail and nearly all of those already
CHECK-failed on failure. Add a new overload for that case, and add a location parameter for the one remaining call.