ImplWitness
#4679
Draft
ImplWitness
#4679
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
InterfaceWitness->ImplWitnessSpecificIdin theImplWitness. This allows theInstBlockit contains to have its own identity, allowing it to be changed as the impl is processed. Evaluation only updates the specific.ImplWitnessat the start of the impl definition. In the future, this will be populated with the values of non-function associated constants. For now, it starts full of invalid instruction ids.Note that the non-SemIR testdata changes are to this file:
toolchain/check/testdata/impl/lookup/fail_todo_undefined_impl.carbonFIXME: exception are these files which shouldn't be different once this PR works:
toolchain/check/testdata/struct/import.carbontoolchain/check/testdata/struct/no_prelude/import.carbontoolchain/check/testdata/tuple/import.carbon