Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not resolve the declaration when forming a specific for use in an eval block #4692

Merged
merged 1 commit into from
Dec 17, 2024

Conversation

josh11b
Copy link
Contributor

@josh11b josh11b commented Dec 17, 2024

When substituting into a generic in order to form a generic eval block, we form SpecificIds to track the list of arguments that should eventually be used to form a specific referenced by the eval block. Values within that specific are not needed and won't ever be used, so it's safe to skip forming them in the first place.

@josh11b josh11b requested a review from zygoloid December 17, 2024 00:01
@github-actions github-actions bot requested a review from jonmeow December 17, 2024 00:01
@zygoloid zygoloid changed the title Less redundant specifics Do not resolve the declaration when forming a specific for use in an eval block Dec 17, 2024
@zygoloid
Copy link
Contributor

I've made some updates to the title and description. I'm not merging so you have a chance to review and update them as you see fit :) Please merge once you're happy with them.

@josh11b josh11b added this pull request to the merge queue Dec 17, 2024
Merged via the queue into carbon-language:trunk with commit b25117b Dec 17, 2024
10 checks passed
@josh11b josh11b deleted the specific branch December 17, 2024 00:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants