Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change Dump functions to static where appropriate. #4712

Merged
merged 1 commit into from
Dec 19, 2024
Merged

Change Dump functions to static where appropriate. #4712

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions toolchain/check/BUILD
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,8 +95,6 @@ cc_library(
cc_library(
name = "dump",
srcs = ["dump.cpp"],
# Contains Dump methods without a forward declaration.
copts = ["-Wno-missing-prototypes"],
deps = [
":context",
"//common:check",
Expand Down
6 changes: 3 additions & 3 deletions toolchain/check/dump.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,17 +57,17 @@ static auto DumpNoNewline(const Context& context, SemIR::LocId loc_id) -> void {
}
}

LLVM_DUMP_METHOD auto Dump(const Context& context, Lex::TokenIndex token)
LLVM_DUMP_METHOD static auto Dump(const Context& context, Lex::TokenIndex token)
-> void {
Parse::Dump(context.parse_tree(), token);
}

LLVM_DUMP_METHOD auto Dump(const Context& context, Parse::NodeId node_id)
LLVM_DUMP_METHOD static auto Dump(const Context& context, Parse::NodeId node_id)
-> void {
Parse::Dump(context.parse_tree(), node_id);
}

LLVM_DUMP_METHOD auto Dump(const Context& context, SemIR::LocId loc_id)
LLVM_DUMP_METHOD static auto Dump(const Context& context, SemIR::LocId loc_id)
-> void {
DumpNoNewline(context, loc_id);
llvm::errs() << '\n';
Expand Down
Loading