Cleanups in parser and parser tests. #473
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
parsing code a little more readable.
|
🎉 Great news! Looks like all the dependencies have been resolved: 💡 To add or remove a dependency please update this issue/PR description. Brought to you by Dependent Issues (:robot: ). Happy coding! |
fowles
approved these changes
Apr 20, 2021
| @@ -316,6 +316,26 @@ auto MatchNode(Args... args) -> ExpectedNode { | |||
| return MatchNode(ParseNodeKind::kind(), args...); \ | |||
| } | |||
| #include "parse_node_kind.def" | |||
|
|
|||
| // Helper for matching a designator `lhs.rhs`. | |||
| auto MatchDesignator(ExpectedNode lhs, std::string rhs) -> ExpectedNode { | |||
There was a problem hiding this comment.
Added std::move here and also in the other matchers. (I'd not been worrying too much about copies in this test-only code but I suppose we could end up doing a lot of vector deep copies here.)
These contain `vector<ExpectedNode>`s, resulting in deep copies of potentially large trees.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #470.