Adds emacs mode for carbon #4874
Open
+77
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tested by opening examples/ and core/. As the language is flushed out more, we can add more but deriving from c-mode works for now. Going to roughly design it similar to cuda-mode.el on emacswiki. Also adds elisp to license pre-commit hook
github-actions
bot
added
infrastructure
utilities
josh11b
reviewed
Feb 5, 2025
| EMACS_MODULES=$HOME/.emacs.d/lisp | ||
|
|
||
| # Next line enforces that we run this test within the same directory. | ||
| cp ./carbon-mode.el $EMACS_MODULES |
There was a problem hiding this comment.
Doesn't do the right thing if the directory doesn't exist.
Suggested change
| cp ./carbon-mode.el $EMACS_MODULES | |
| mkdir -p $EMACS_MODULES | |
| cp ./carbon-mode.el $EMACS_MODULES/ |
| # Next line enforces that we run this test within the same directory. | ||
| cp ./carbon-mode.el $EMACS_MODULES | ||
|
|
||
| emacs --eval "(require 'carbon-mode)" ../../examples/sieve.carbon -f carbon-mode & |
There was a problem hiding this comment.
I get an "emacs: standard input is not a tty" error here.
Also, it doesn't make sense to put this in the background:
Suggested change
| emacs --eval "(require 'carbon-mode)" ../../examples/sieve.carbon -f carbon-mode & | |
| emacs --eval "(require 'carbon-mode)" ../../examples/sieve.carbon -f carbon-mode |
| 2. add to config | ||
|
|
||
| ```emacs-lisp | ||
| (require 'carbon-mode) |
There was a problem hiding this comment.
These instructions assume that (push "~/.emacs.d/lisp" load-path) is in your .emacs file, and so should instruct people to add it if it is not already there.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tested by opening examples/ and core/.
As the language is flushed out more, we can add more but deriving from cc-mode works for now.
Also adds elisp to license pre-commit hook.