Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve description of what belongs in a proposal document versus in the design #649

Merged
merged 9 commits into from
Jul 26, 2021
Merged

Improve description of what belongs in a proposal document versus in the design #649

merged 9 commits into from
Jul 26, 2021

Commits on Jul 14, 2021

  1. Improve description of what belongs in a proposal document versus in … 

    …the design

Expand the description of the structure of a proposal PR. Clarify that
the full PR is the proposal, not only the P-numbered document. Start a
design style guide and use it to describe which parts of a proposal
should not end up in the design.
    @zygoloid
    zygoloid committed Jul 14, 2021
    Configuration menu
    Copy the full SHA
    1f5d6df View commit details
    Browse the repository at this point in the history

Commits on Jul 21, 2021

  1. Apply suggestions from code review 

    Co-authored-by: Jon Meow <46229924+jonmeow@users.noreply.github.com>
    @zygoloid @jonmeow
    zygoloid and jonmeow authored Jul 21, 2021
    Configuration menu
    Copy the full SHA
    4b59bee View commit details
    Browse the repository at this point in the history

  2. -> `.

    @zygoloid
    zygoloid committed Jul 21, 2021
    Configuration menu
    Copy the full SHA
    6c47c50 View commit details
    Browse the repository at this point in the history

  3. Updates based on further process discussion and clarification around the 

    purpose of docs/design.
    @zygoloid
    zygoloid committed Jul 21, 2021
    Configuration menu
    Copy the full SHA
    9b19fa9 View commit details
    Browse the repository at this point in the history

  4. Apply suggestions from code review 

    Co-authored-by: Jon Meow <46229924+jonmeow@users.noreply.github.com>
    @zygoloid @jonmeow
    zygoloid and jonmeow authored Jul 21, 2021
    Configuration menu
    Copy the full SHA
    67715b7 View commit details
    Browse the repository at this point in the history

  5. Prettier fixes and consistency fixes.

    @zygoloid
    zygoloid committed Jul 21, 2021
    Configuration menu
    Copy the full SHA
    39ab765 View commit details
    Browse the repository at this point in the history

Commits on Jul 22, 2021

  1. Reduce redundancy.

    @zygoloid
    zygoloid committed Jul 22, 2021
    Configuration menu
    Copy the full SHA
    b677b29 View commit details
    Browse the repository at this point in the history

Commits on Jul 23, 2021

  1. Pre-commit fix.

    @zygoloid
    zygoloid committed Jul 23, 2021
    Configuration menu
    Copy the full SHA
    9ffc8a2 View commit details
    Browse the repository at this point in the history

Commits on Jul 26, 2021

  1. Improvements from review.

    @zygoloid
    zygoloid committed Jul 26, 2021
    Configuration menu
    Copy the full SHA
    53b0399 View commit details
    Browse the repository at this point in the history