Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Member access expressions #989

Merged
merged 39 commits into from
Mar 2, 2022
Merged

Member access expressions #989

merged 39 commits into from
Mar 2, 2022

Commits on Dec 15, 2021

  1. Initial design changes for member access expressions

    @zygoloid
    zygoloid committed Dec 15, 2021
    Configuration menu
    Copy the full SHA
    df43587 View commit details
    Browse the repository at this point in the history

  2. Filling out template with PR 989

    @zygoloid
    zygoloid committed Dec 15, 2021
    Configuration menu
    Copy the full SHA
    b72d322 View commit details
    Browse the repository at this point in the history

Commits on Dec 16, 2021

  1. Rules for member access naming interface members.

    @zygoloid
    zygoloid committed Dec 16, 2021
    Configuration menu
    Copy the full SHA
    efe4d73 View commit details
    Browse the repository at this point in the history

Commits on Jan 18, 2022

  1. Merge branch 'trunk' into proposal-member-access-expres

    @zygoloid
    zygoloid committed Jan 18, 2022
    Configuration menu
    Copy the full SHA
    9a5da20 View commit details
    Browse the repository at this point in the history

Commits on Jan 19, 2022

  1. Text improvements

    @zygoloid
    zygoloid committed Jan 19, 2022
    Configuration menu
    Copy the full SHA
    9e7e021 View commit details
    Browse the repository at this point in the history

  2. Add proposal text.

    @zygoloid
    zygoloid committed Jan 19, 2022
    Configuration menu
    Copy the full SHA
    4ea4f73 View commit details
    Browse the repository at this point in the history

  3. Undo some damage done by prettier.

    @zygoloid
    zygoloid committed Jan 19, 2022
    Configuration menu
    Copy the full SHA
    46dde7f View commit details
    Browse the repository at this point in the history

Commits on Jan 20, 2022

  1. Switch from blockquote to bullets to work around prettier bug.

    @zygoloid
    zygoloid committed Jan 20, 2022
    Configuration menu
    Copy the full SHA
    138470d View commit details
    Browse the repository at this point in the history

Commits on Jan 21, 2022

  1. Add some cross-references to proposal background.

    @zygoloid
    zygoloid committed Jan 21, 2022
    Configuration menu
    Copy the full SHA
    5413d9b View commit details
    Browse the repository at this point in the history

Commits on Jan 22, 2022

  1. Address review comments.

    @zygoloid
    zygoloid committed Jan 22, 2022
    Configuration menu
    Copy the full SHA
    93d9563 View commit details
    Browse the repository at this point in the history

  2. Apply suggestions from code review 

    Co-authored-by: josh11b <josh11b@users.noreply.github.com>
    @zygoloid @josh11b
    zygoloid and josh11b authored Jan 22, 2022
    Configuration menu
    Copy the full SHA
    9ac1f4d View commit details
    Browse the repository at this point in the history

  3. Address review comments.

    @zygoloid
    zygoloid committed Jan 22, 2022
    Configuration menu
    Copy the full SHA
    5cf7eb1 View commit details
    Browse the repository at this point in the history

  4. Add missing external.

    @zygoloid
    zygoloid committed Jan 22, 2022
    Configuration menu
    Copy the full SHA
    ea19037 View commit details
    Browse the repository at this point in the history

  5. Add another couple of externals.

    @zygoloid
    zygoloid committed Jan 22, 2022
    Configuration menu
    Copy the full SHA
    0cb68a7 View commit details
    Browse the repository at this point in the history

  6. Address review comment.

    @zygoloid
    zygoloid committed Jan 22, 2022
    Configuration menu
    Copy the full SHA
    f7f78d2 View commit details
    Browse the repository at this point in the history

Commits on Jan 24, 2022

  1. Summarize member access in a table and use more meaningful names in 

    some additional examples.
    @zygoloid
    zygoloid committed Jan 24, 2022
    Configuration menu
    Copy the full SHA
    5ad6bc3 View commit details
    Browse the repository at this point in the history

  2. Flesh out "alternatives considered".

    @zygoloid
    zygoloid committed Jan 24, 2022
    Configuration menu
    Copy the full SHA
    6120907 View commit details
    Browse the repository at this point in the history

Commits on Jan 25, 2022

  1. Apply suggestions from code review 

    Co-authored-by: josh11b <josh11b@users.noreply.github.com>
    @zygoloid @josh11b
    zygoloid and josh11b authored Jan 25, 2022
    Configuration menu
    Copy the full SHA
    aa8d643 View commit details
    Browse the repository at this point in the history

  2. Missing update a -> n when switching example to nicer names. 

    Co-authored-by: josh11b <josh11b@users.noreply.github.com>
    @zygoloid @josh11b
    zygoloid and josh11b authored Jan 25, 2022
    Configuration menu
    Copy the full SHA
    0652f27 View commit details
    Browse the repository at this point in the history

Commits on Jan 26, 2022

  1. Restructure: add better summary and overview at the start and explain 

    the steps before we go into detail.
    @zygoloid
    zygoloid committed Jan 26, 2022
    Configuration menu
    Copy the full SHA
    eeee8ee View commit details
    Browse the repository at this point in the history

  2. Attempt to clarify in response to review comments.

    @zygoloid
    zygoloid committed Jan 26, 2022
    Configuration menu
    Copy the full SHA
    70903f8 View commit details
    Browse the repository at this point in the history

  3. Reflow to appease prettier.

    @zygoloid
    zygoloid committed Jan 26, 2022
    Configuration menu
    Copy the full SHA
    735abac View commit details
    Browse the repository at this point in the history

  4. Apply suggestions from code review 

    Co-authored-by: josh11b <josh11b@users.noreply.github.com>
    @zygoloid @josh11b
    zygoloid and josh11b authored Jan 26, 2022
    Configuration menu
    Copy the full SHA
    c6afd28 View commit details
    Browse the repository at this point in the history

  5. Respond to review comments.

    @zygoloid
    zygoloid committed Jan 26, 2022
    Configuration menu
    Copy the full SHA
    3ed3a43 View commit details
    Browse the repository at this point in the history

Commits on Jan 27, 2022

  1. Add elided word back for clarity.

    @zygoloid
    zygoloid authored Jan 27, 2022
    Configuration menu
    Copy the full SHA
    a241782 View commit details
    Browse the repository at this point in the history

  2. Attempt to clarify that lookup never considers the values of in-scope… 

    … generic parameters.
    @zygoloid
    zygoloid committed Jan 27, 2022
    Configuration menu
    Copy the full SHA
    0d169e4 View commit details
    Browse the repository at this point in the history

Commits on Feb 1, 2022

  1. Apply suggestions from code review 

    Co-authored-by: josh11b <josh11b@users.noreply.github.com>
    @zygoloid @josh11b
    zygoloid and josh11b authored Feb 1, 2022
    Configuration menu
    Copy the full SHA
    05c41ef View commit details
    Browse the repository at this point in the history

  2. Clarify that we're not giving an example of a rewrite rule, just an 

    equivalence.
    @zygoloid
    zygoloid committed Feb 1, 2022
    Configuration menu
    Copy the full SHA
    babfee7 View commit details
    Browse the repository at this point in the history

  3. Response to review comments.

    @zygoloid
    zygoloid committed Feb 1, 2022
    Configuration menu
    Copy the full SHA
    4d9c39c View commit details
    Browse the repository at this point in the history

  4. Remove table of cases; it doesn't seem to pull its weight.

    @zygoloid
    zygoloid committed Feb 1, 2022
    Configuration menu
    Copy the full SHA
    b9427a4 View commit details
    Browse the repository at this point in the history

  5. Factor out wording about combining lookup results and say that it takes 

    impl lookup into account.
    @zygoloid
    zygoloid committed Feb 1, 2022
    Configuration menu
    Copy the full SHA
    27335b7 View commit details
    Browse the repository at this point in the history

Commits on Feb 2, 2022

  1. Expand explanation in example. 

    Co-authored-by: josh11b <josh11b@users.noreply.github.com>
    @zygoloid @josh11b
    zygoloid and josh11b authored Feb 2, 2022
    Configuration menu
    Copy the full SHA
    2c09a73 View commit details
    Browse the repository at this point in the history

  2. Add discussion of alternative interpretation of Type.Interface.

    @zygoloid
    zygoloid committed Feb 2, 2022
    Configuration menu
    Copy the full SHA
    207347b View commit details
    Browse the repository at this point in the history

  3. Merge branch 'trunk' into proposal-member-access-expres

    @zygoloid
    zygoloid committed Feb 2, 2022
    Configuration menu
    Copy the full SHA
    e8a820c View commit details
    Browse the repository at this point in the history

  4. Fix trailing whitespace.

    @zygoloid
    zygoloid committed Feb 2, 2022
    Configuration menu
    Copy the full SHA
    751f02e View commit details
    Browse the repository at this point in the history

Commits on Mar 2, 2022

  1. Respond to review comments.

    @zygoloid
    zygoloid committed Mar 2, 2022
    Configuration menu
    Copy the full SHA
    a3bddec View commit details
    Browse the repository at this point in the history

  2. Merge branch 'trunk' into proposal-member-access-expres 

    Update precedence graph for new functionality.
    @zygoloid
    zygoloid committed Mar 2, 2022
    Configuration menu
    Copy the full SHA
    dfab250 View commit details
    Browse the repository at this point in the history

  3. Attempt to fix mermaid error: don't use underscore in node name.

    @zygoloid
    zygoloid committed Mar 2, 2022
    Configuration menu
    Copy the full SHA
    3f80189 View commit details
    Browse the repository at this point in the history

  4. Fix '->' typo in mermaid diagram.

    @zygoloid
    zygoloid committed Mar 2, 2022
    Configuration menu
    Copy the full SHA
    3ae955c View commit details
    Browse the repository at this point in the history