Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

116 intern balance refactor 1 step minter #123

Merged
merged 18 commits into from
Aug 9, 2024
Merged

116 intern balance refactor 1 step minter #123

merged 18 commits into from
Aug 9, 2024

Conversation

julienbrs
Copy link
Collaborator

No description provided.

@julienbrs julienbrs requested a review from tekkac July 31, 2024 16:26
@julienbrs julienbrs self-assigned this Jul 31, 2024
tekkac
tekkac reviewed Aug 1, 2024
View reviewed changes
Copy link
Contributor

@tekkac tekkac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need both initial_supply and max_money_amount?

src/components/minter/mint.cairo Outdated Show resolved Hide resolved
src/contracts/project.cairo Outdated Show resolved Hide resolved
src/models/carbon_vintage.cairo Show resolved Hide resolved
tests/tests_lib.cairo Outdated Show resolved Hide resolved
@julienbrs julienbrs marked this pull request as ready for review August 8, 2024 17:11
@tekkac tekkac self-requested a review August 9, 2024 07:37
tekkac
tekkac previously approved these changes Aug 9, 2024
View reviewed changes
Copy link
Contributor

@tekkac tekkac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 💪
run scarb fmt :)

src/contracts/project.cairo Outdated Show resolved Hide resolved
tests/tests_lib.cairo Outdated Show resolved Hide resolved
@julienbrs julienbrs merged commit 12b2a6d into carbonable-labs:main Aug 9, 2024
2 checks passed
@julienbrs julienbrs deleted the 116-intern-balance-refactor-1-step-minter branch August 9, 2024 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tekkac tekkac tekkac left review comments

Assignees

@julienbrs julienbrs

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@julienbrs @tekkac