"bundle update" #265
Merged
"bundle update" #265
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It is a sprockets 4.0.0 thing and this is the solution (I verified it locally): rails/sprockets#597 (comment) |
|
@mattbrictson do you have a moment to push a commit? |
|
✅ Done |
christiannelson
force-pushed
the
bundle-update
branch
from
3b5ebb6 to
975de7d
Compare
In sprockets 4.0.0, the `link_directory ../stylesheets .css` directive causes sprockets to process all `.scss` files in an arbitrary order, regardless of any `@import` statements. This leads to undefined variable errors when e.g. the file using a variable is processed before the file that defines it. Fix by explicitly rooting the sprockets manifest at `application.css`, as suggested here: rails/sprockets#597 (comment)
christiannelson
force-pushed
the
bundle-update
branch
from
975de7d to
e91b01a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrade dependencies.
Draft because this is failing locally and I want to see if it fails elsewhere.