Run autocorrections using c5-conventions/rubocop #147
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Shouldn't we eat our own dog food?
This repo was way out of sync with our current rubocop conventions.
Solution
Bring it up to speed.
Because we don't have
rubocop
in the project, this can be seen asa one-time cleanup. We can decide later if we want it more persistent.
But for now I did the following:
.rubocop.yml
fromcarbonfive/c5-conventions
curl https://raw.githubusercontent.com/carbonfive/c5-conventions/master/rubocop/rubocop.yml > .rubocop.yml
rubocop
andrubocop-performance
gems