Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Require ruby 2.4 or greater #151

Merged
merged 1 commit into from
Jan 24, 2020
Merged

Require ruby 2.4 or greater #151

merged 1 commit into from
Jan 24, 2020

Conversation

bunnymatic
Copy link
Contributor

Problem

Upcoming work which will introduce Rubocop will likely introduce
code changes that may not be supported for older versions of ruby.

Because ruby < 2.4 is officially EOL, we should be able to require at least 2.4.

Solution

Require ruby >= 2.4 in the gemspec.

EOL Ruby : https://endoflife.software/programming-languages/server-side-scripting/ruby

Problem
-------

Upcoming work which will introduce Rubocop will likely introduce
code changes that may not be supported for older versions of ruby.

Because ruby < 2.4 is officially EOL, we should be able to require at least 2.4.

Solution
--------

Require ruby >= 2.4 in the gemspec.

EOL Ruby : https://endoflife.software/programming-languages/server-side-scripting/ruby
@bunnymatic
Copy link
Contributor Author

This is a precursor to both #152, #148 as new Rubocop makes a few changes that require a modern ruby.

@bunnymatic bunnymatic mentioned this pull request Jan 24, 2020
Copy link
Contributor

@mattbrictson mattbrictson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💎 🆙

@bunnymatic bunnymatic merged commit 6b38b61 into master Jan 24, 2020
@bunnymatic bunnymatic deleted the chores/require-ruby-2.4 branch January 24, 2020 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants