Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

multivariate gard implementation #229

Merged
merged 13 commits into from
Jun 30, 2022
Merged

multivariate gard implementation #229

merged 13 commits into from
Jun 30, 2022

Conversation

orianac
Copy link
Member

@orianac orianac commented Jun 15, 2022

as committed here ran a test case for western US using three features to predict precip. note that this will break any caching schemes previously set up as the run_id now includes the feature names.

flow is functional at this point with a few remaining TODOs:

  • read in u/v winds from era5
  • read in u/v winds from cmip
  • read in pressure from era5
  • read in pressure from cmip
  • accommodate different transformations/detrending of different variables
  • attr adjustment is hardcoded inside observations.py - add the additional variables (and consider reading those attr spec from somewhere else or maybe moving that attr adjustment to somewhere else)
  • confirm that variables are passed correctly (order, shape) to sklearn
  • why are there negative values in bias-corrected precip (see example in tasks.py)

@jhamman

predict precip - a couple remaining TODOs but functional at this point
@vercel
Copy link

vercel bot commented Jun 15, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated
cmip6-downscaling ⬜️ Ignored (Inspect) Jun 30, 2022 at 4:34PM (UTC)

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@norlandrhagen
Copy link
Contributor

pre-commit.ci autofix

@norlandrhagen norlandrhagen merged commit 895fac3 into main Jun 30, 2022
@norlandrhagen norlandrhagen deleted the multivariate_gard branch June 30, 2022 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants