-
-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add information about pyramid structure and metadata schema #89
Conversation
@katamartin would you be willing to review https://ndpyramid--89.org.readthedocs.build/en/89/schema.html for accuracy, since it references a lot of |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks really great -- thank you for putting it together!! Left a few small comments, but generally looks good to me!
docs/schema.md
Outdated
} | ||
``` | ||
|
||
If the `"crs"` attribute is not included, the pyramid levels are assumed to be in the Web Mercator projection. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@carbonplan/maps
doesn't actually use crs
currently, though it certainly could!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, good to know! Is this hard-coded in a maps deployment instead?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, both projection and Zarr version are currently configured via props passed to @carbonplan/maps
components.
|
||
- Consistent chunk size across pyramid levels (128, 256, or 512 are recommended) | ||
- [zlib](https://numcodecs.readthedocs.io/en/stable/zlib.html) or [gzip](https://numcodecs.readthedocs.io/en/stable/gzip.html) compression | ||
- Web Mercator (EPSG:3857) or Equidistant Cylindrical (EPSG:4326) projection |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point, thanks! Since V3 is experimental, I'll just reference the V2 dtypes
Co-authored-by: Kata Martin <katasm@gmail.com>
Fixes #78, #88