Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CNTools 8.2.0 #895

Merged
merged 16 commits into from
Apr 21, 2021
Merged

CNTools 8.2.0 #895

merged 16 commits into from
Apr 21, 2021

Conversation

Scitz0
Copy link
Contributor

@Scitz0 Scitz0 commented Apr 17, 2021

Added

Changed

  • Redesigned input handling to be more flexible and improve output

Many line changes due to some code refactoring for println and the new ask function to handle input

# Added
- Ability to create & update a Cardano Token Registry submission JSON file
  - Requires 'token-metadata-creator' tool, instructions to download/build this tool added to Guild Operators documentation:
  - https://cardano-community.github.io/guild-operators/#/Build/offchainMetadataTools
- Token Registry lookup in Wallet >> Show
- Token asset fingerprint generation according to cardano-foundation/CIPs#64

# Changed
- Redesigned input handling to be more flexible and improve output

Many line changes due to some code refactoring for println and the new ask function to handle input
@Scitz0 Scitz0 requested a review from rdlrt April 17, 2021 15:16
…retire rest, add some info for offline workflow, and update build diagram
Copy link
Contributor

@rdlrt rdlrt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, some comments tho to move some common functions to env if possible and makes sense

@Scitz0
Copy link
Contributor Author

Scitz0 commented Apr 19, 2021

Moved a bunch of potential common functions from CNTools library to env. Could be that more can be moved but these were the obvious ones.

@rdlrt As this required a somewhat major code re-write I suggest you have a check before merge.

@Scitz0
Copy link
Contributor Author

Scitz0 commented Apr 19, 2021

Tagged as do-not-merge for now as some recent commits change fundamental code as internal update and common functions.

@rdlrt
Copy link
Contributor

rdlrt commented Apr 21, 2021

LGTM

@Scitz0 Scitz0 merged commit a109e5c into alpha Apr 21, 2021
@Scitz0 Scitz0 deleted the cntools-token-registry branch April 21, 2021 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants