Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CIP-0074 | Set minPoolCost to 0 #358

Merged
merged 8 commits into from
Nov 9, 2022
Merged

CIP-0074 | Set minPoolCost to 0 #358

merged 8 commits into from
Nov 9, 2022

Conversation

ADARobinHood
Copy link
Contributor

@ADARobinHood ADARobinHood commented Oct 20, 2022 •
edited by rphair
Loading

@ADARobinHood ADARobinHood changed the title Create CIP 69? - Set minPoolCost to 0 CIP-0069? | Set minPoolCost to 0 Oct 20, 2022
@kieransimkin
Copy link
Contributor

👍👍🏻👍🏼👍🏽👍🏾👍🏿

@KtorZ KtorZ changed the title CIP-0069? | Set minPoolCost to 0 Set minPoolCost to 0 Oct 21, 2022
@rphair
Copy link
Collaborator

rphair commented Oct 24, 2022 •
edited
Loading

@ADARobinHood as I just wrote in #360 (comment) (so I'm copying parts of the text) there's a lot of common ground between these 2 proposals as you've observed from the Cardano Forum thread especially where @TobiasFancee jumped in: https://forum.cardano.org/t/cip-69-set-minpoolcost-to-0/109309/37

Discord has been used to compare & contrast several PoS proposals and some suggested variations so please let me invite you there as well: my apologies if you've already been there but I can't line up your name with any of the participants:

... nice to see this begin on the Cardano Forum with such enthusiastic discussion. I've recommended an upcoming Biweekly CIP Editors' meeting to have a scope of all CIPs with this theme (revisions to PoS rewards & incentives), since a couple more of them including yours have come in recently. If such an agenda is confirmed I'll post it here.

The Discord where we have these meetings online (invite) also has a #rss-discussions channel covering multiple CIPs for PoS revisions (I've asked the admin to rename it more generally; hopefully will happen soon). I didn't see you there yet & it would be great to have you included in that discussion. It tends to have more detail & "brainstorming" than we ever see on the GitHub thread, and also more focused peer review than on the Cardano Forum. 😎

rphair
rphair reviewed Oct 24, 2022
View reviewed changes
Copy link
Collaborator

@rphair rphair left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

BTW so we can review this properly, please rename the document currently at this pathname: CIP 69? - Set minPoolCost to 0
to: README.md
and move the file into a descriptively named subdirectory: preferably something short beginning with CIP but not using a number.

CIP 69? - Set minPoolCost to 0 Outdated Show resolved Hide resolved
CIP 69? - Set minPoolCost to 0 Outdated Show resolved Hide resolved
@rphair rphair changed the title Set minPoolCost to 0 CIP-???? | Set minPoolCost to 0 Oct 25, 2022
ADARobinHood
ADARobinHood commented Nov 3, 2022
View reviewed changes
Copy link
Contributor Author

@ADARobinHood ADARobinHood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Formatting corrections

ADARobinHood
ADARobinHood commented Nov 3, 2022
View reviewed changes
Copy link
Contributor Author

@ADARobinHood ADARobinHood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo fix

KtorZ
KtorZ reviewed Nov 8, 2022
View reviewed changes
CIP minPoolCost 0/README.md Outdated Show resolved Hide resolved
CIP minPoolCost 0/README.md Outdated Show resolved Hide resolved
CIP minPoolCost 0/README.md Outdated Show resolved Hide resolved
CIP minPoolCost 0/README.md Outdated Show resolved Hide resolved
@ADARobinHood @KtorZ
Apply suggestions from code review
7a2a894 
Co-authored-by: Matthias Benkort <5680256+KtorZ@users.noreply.github.com>
@KtorZ
Copy link
Member

KtorZ commented Nov 8, 2022

We discussed this proposal in today's editors meeting (number 57). As for other proposals regarding the reward sharing scheme or the ledger rule, the proposal shall be merged as Proposed (with the above addition) while the founding members work with the community on a framework to review and proceed with changes in those areas of the protocol (see discussion in the -- upcoming -- meeting notes)

ADARobinHood
ADARobinHood commented Nov 8, 2022
View reviewed changes
Copy link
Contributor Author

@ADARobinHood ADARobinHood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changes

KtorZ
KtorZ requested changes Nov 8, 2022
View reviewed changes
CIP minPoolCost 0/README.md Outdated Show resolved Hide resolved
CIP minPoolCost 0/README.md Outdated Show resolved Hide resolved
@KtorZ KtorZ changed the title CIP-???? | Set minPoolCost to 0 CIP-0073? | Set minPoolCost to 0 Nov 8, 2022
@ADARobinHood @KtorZ
Apply suggestions from code review
3bd3053 
Co-authored-by: Matthias Benkort <5680256+KtorZ@users.noreply.github.com>
ADARobinHood
ADARobinHood commented Nov 8, 2022
View reviewed changes
Copy link
Contributor Author

@ADARobinHood ADARobinHood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@KtorZ
Copy link
Member

KtorZ commented Nov 8, 2022 •
edited
Loading

(@ADARobinHood can you also adjust the folder name to 'CIP-0074' 🙏)

@KtorZ KtorZ changed the title CIP-0073? | Set minPoolCost to 0 CIP-0074? | Set minPoolCost to 0 Nov 8, 2022
rphair
rphair approved these changes Nov 9, 2022
View reviewed changes
Copy link
Collaborator

@rphair rphair left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All in order as per yesterday's CIP meeting resolution & the new Path to Active.

@rphair rphair merged commit f6c5136 into cardano-foundation:master Nov 9, 2022
@rphair rphair changed the title CIP-0074? | Set minPoolCost to 0 CIP-0074 | Set minPoolCost to 0 May 24, 2023
@rphair rphair mentioned this pull request Jul 11, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rphair rphair rphair approved these changes

@KtorZ KtorZ KtorZ approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ADARobinHood @kieransimkin @rphair @KtorZ