Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CIP-0036 | Fixed incorrect CDDL notation and incorrect keys in test vectors #426

Merged
merged 1 commit into from
Jan 17, 2023
Merged

CIP-0036 | Fixed incorrect CDDL notation and incorrect keys in test vectors #426

merged 1 commit into from
Jan 17, 2023

Conversation

Ryun1
Copy link
Collaborator

@Ryun1 Ryun1 commented Jan 11, 2023 •
edited
Loading

Raised to address the issues spotted by @rooooooooob in #425

Changes

  • Corrected CDDL notation so that the delegations field contains nested arrays.
  • Changed title of testvectors file to CIP36, it was labelled incorrectly.
  • Regenerated test vectors as needed, the issues were:
    • Stake keys did not match between the "Data to sign" and "Output" sections for legacy and new.
    • Voting key used did not match between "Data to sign" and CBOR encoding for legacy, which lead to subsequent sections being incorrect.

cc: @kevinhammond, @stevenj, @rphair

@Ryun1 Ryun1 mentioned this pull request Jan 11, 2023
Closed
@kevinhammond
Copy link
Contributor

Thank you for fixing this, @Ryun1

@rphair rphair added the Correction Fixing minor issue or typo label Jan 11, 2023
rphair
rphair approved these changes Jan 11, 2023
View reviewed changes
Copy link
Collaborator

@rphair rphair left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can compare strings but I don't have deep understanding of this issue: the OP of #425 and peer reviews are good enough for me though.

rooooooooob
rooooooooob approved these changes Jan 11, 2023
View reviewed changes
Copy link
Contributor

@rooooooooob rooooooooob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the quick response

@KtorZ KtorZ merged commit 0931388 into cardano-foundation:master Jan 17, 2023
@rphair rphair mentioned this pull request Jan 20, 2023
Merged
@Ryun1 Ryun1 mentioned this pull request Mar 7, 2023
Merged
Ryun1 added a commit to Ryun1/CIPs that referenced this pull request Nov 17, 2023
@Ryun1
Corrected CDDL and fixed test vectors (cardano-foundation#426)
c8766dd
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rphair rphair rphair approved these changes

@SebastienGllmt SebastienGllmt SebastienGllmt approved these changes

@rooooooooob rooooooooob rooooooooob approved these changes

@KtorZ KtorZ KtorZ approved these changes

@janmazak janmazak janmazak approved these changes

Assignees
No one assigned
Labels
Correction Fixing minor issue or typo
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@Ryun1 @kevinhammond @rphair @SebastienGllmt @rooooooooob @KtorZ @janmazak